Update documentation about non-deterministic diameter with multiple workers #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmy
reviewed
Jun 12, 2024
| When using multiple workers on a medium-small model, the reported <i>Diameter</i> might | ||
| differ across runs. | ||
| This is a limitation we accept to avoid putting additional synchronization that would limit | ||
| the scalability of the visit. For small models, use a single worker. For large models, |
There was a problem hiding this comment.
Perhaps just "that would limit scalability"?
lemmy
reviewed
Jun 12, 2024
| @@ -96,6 +101,8 @@ <h3><a name="model-mode">Model-checking mode</a></h3> | |||
| queue, so it does not produce any | |||
| <i>Diameter</i> or <i>Queue size</i> | |||
| statistics. | |||
| Additionally, <em>Depth-first</em> option doesn't currently | |||
There was a problem hiding this comment.
The confusion typically comes from the fact that TLC does not plain depth-first but depth-first iterative deepening (DFID). We should consistently call it by its full name.
There was a problem hiding this comment.
Thanks for the insight! I've updated the paragraph.
lemmy
reviewed
Jun 12, 2024
general/docs/current-tools.md
Outdated
| @@ -30,6 +30,10 @@ ISpec == IM!Spec | |||
|
|
|||
| TLC cannot handle natural numbers greater than 2<sup>31</sup> - 1. | |||
|
|
|||
| When running the model checking in BFS mode with multiple workers on a medium-small model, the reported diameter might differ across runs. | |||
| This is a limitation we accept to avoid putting additional synchronization that would limit the scalability of the visit. | |||
There was a problem hiding this comment.
Perhaps just "that would limit scalability"?
FedericoPonzi
force-pushed
the
issue-883
branch
2 times, most recently
from
2fe9752 to
5e840cd
Compare
Persist the learning from issue tlaplus#883. Diameter is non-deterministic when the BFS is run with multiple workers. Signed-off-by: Federico Ponzi <me@fponzi.me>
lemmy
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist the learning from issue #883. Diameter is non-deterministic when the BFS is run with multiple workers.