Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-mc: add page #15356

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

llvm-mc: add page #15356

wants to merge 6 commits into from
+25 −0

Conversation

P2Tree
Copy link

@P2Tree P2Tree commented Dec 26, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): LLVM 19

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Dec 26, 2024
spageektti
spageektti reviewed Dec 27, 2024
View reviewed changes
pages/common/llvm-mc.md Outdated Show resolved Hide resolved
spageektti
spageektti approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you so much for your contribution!

@P2Tree @spageektti
Update pages/common/llvm-mc.md
7514c88 
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
@P2Tree
Copy link
Author

P2Tree commented Dec 28, 2024

Hi. Thank you so much for your contribution!

This is my first PR for tldr, thanks for your review.
Should I need to update this issue after PR merged? #6367

sebastiaanspeck
sebastiaanspeck requested changes Dec 28, 2024
View reviewed changes
pages/common/llvm-mc.md Outdated Show resolved Hide resolved
P2Tree and others added 2 commits December 28, 2024 14:28
@P2Tree @sebastiaanspeck
Update pages/common/llvm-mc.md
7282cde 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@P2Tree
Merge branch 'main' into llvm-mc
ae49d8b
@spageektti
Copy link
Member

Hi. Thank you so much for your contribution!

This is my first PR for tldr, thanks for your review.
Should I need to update this issue after PR merged? #6367

I will update the list.

@spageektti spageektti mentioned this pull request Dec 28, 2024
Open
sebastiaanspeck
sebastiaanspeck requested changes Dec 29, 2024
View reviewed changes
pages/common/llvm-mc.md

- Assemble assembly code from standard input stream and show encoding to standard output stream:

`echo "addl %eax, %ebx" | llvm-mc -show-encoding -show-inst`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`echo "addl %eax, %ebx" | llvm-mc -show-encoding -show-inst`
`echo "{{addl %eax, %ebx}}" | llvm-mc -show-encoding -show-inst`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck requested changes

@spageektti spageektti spageektti approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P2Tree @spageektti @sebastiaanspeck