fix(core): split view reordering crash #9461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
JimmFly,
EYHN,
forehalo and
CatsJuice
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9461 +/- ##
==========================================
+ Coverage 51.63% 51.67% +0.03%
==========================================
Files 2154 2154
Lines 97039 97039
Branches 16173 16173
==========================================
+ Hits 50104 50142 +38
+ Misses 45608 45566 -42
- Partials 1327 1331 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forehalo
reviewed
Dec 31, 2024
packages/frontend/core/src/modules/workbench/view/split-view/split-view.tsx
Outdated
Show resolved
Hide resolved
pengx17
force-pushed
the
12-31-fix_core_split_view_reordering_crash
branch
from
127bb68 to
a6073f2
Compare
forehalo
reviewed
Dec 31, 2024
packages/frontend/core/src/modules/workbench/view/split-view/split-view.tsx
Outdated
Show resolved
Hide resolved
pengx17
force-pushed
the
12-31-fix_core_split_view_reordering_crash
branch
from
a6073f2 to
3a700d8
Compare
forehalo
approved these changes
Dec 31, 2024
a workaround fix AF-1940
pengx17
force-pushed
the
12-31-fix_core_split_view_reordering_crash
branch
from
3a700d8 to
e3d6813
Compare
Merge activity
|
graphite-app
bot
deleted the
12-31-fix_core_split_view_reordering_crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a workaround fix AF-1940