refactor(core): remove abort event error on init #9465
Merged
+16
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
requested review from
EYHN,
pengx17,
CatsJuice,
forehalo and
JimmFly
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
pengx17
approved these changes
Dec 31, 2024
EYHN
reviewed
Dec 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #9465 +/- ##
==========================================
+ Coverage 52.59% 52.83% +0.24%
==========================================
Files 2151 2151
Lines 96961 96964 +3
Branches 16154 16192 +38
==========================================
+ Hits 51000 51235 +235
+ Misses 44549 44305 -244
- Partials 1412 1424 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
doodlewind
added a commit
that referenced
this pull request
Dec 31, 2024
Following error always throw on Affine init, which is actually an `Event` from abort controller that can be handled in upstream. 
doodlewind
force-pushed
the
doodl/error
branch
from
507f0de to
4862da0
Compare
Merge activity
|
Following error always throw on Affine init, which is actually an `Event` from abort controller that can be handled in upstream. 
doodlewind
force-pushed
the
doodl/error
branch
from
4862da0 to
8227d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following error always throw on Affine init, which is actually an
Eventfrom abort controller that can be handled in upstream.