Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): add native clipboard extension #9502

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jan 3, 2025

Closes: BS-2239

@github-actions github-actions bot added app:electron Related to electron app app:core labels Jan 3, 2025
Copy link
Contributor Author

fundon commented Jan 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon marked this pull request as ready for review January 3, 2025 06:51
@fundon fundon requested a review from a team as a code owner January 3, 2025 06:51

This comment was marked as resolved.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.68%. Comparing base (46c8c4a) to head (b32ff2c).

Files with missing lines Patch % Lines
blocksuite/affine/block-image/src/utils.ts 50.00% 4 Missing ⚠️
...ne/shared/src/services/native-clipboard-service.ts 33.33% 2 Missing ⚠️
...rc/root-block/widgets/surface-ref-toolbar/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9502      +/-   ##
==========================================
- Coverage   52.71%   52.68%   -0.04%     
==========================================
  Files        2162     2163       +1     
  Lines       97373    97368       -5     
  Branches    16231    16228       -3     
==========================================
- Hits        51334    51296      -38     
- Misses      44130    44708     +578     
+ Partials     1909     1364     -545     
Flag Coverage Δ
server-test 78.14% <ø> (ø)
unittest 32.26% <8.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/01_02_add_clipboard_native_extension branch from 1d11337 to ec0edfa Compare January 3, 2025 07:34
Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fundon fundon force-pushed the fundon/01_02_add_clipboard_native_extension branch from ec0edfa to 15c2543 Compare January 3, 2025 10:11
@fundon fundon changed the title refactor(editor): add clipboard native extension refactor(editor): add native clipboard extension Jan 3, 2025
@fundon fundon force-pushed the fundon/01_02_add_clipboard_native_extension branch 2 times, most recently from 14bc7cd to 43b419b Compare January 3, 2025 12:34
@fundon fundon force-pushed the fundon/01_02_add_clipboard_native_extension branch 4 times, most recently from b3ae1e1 to c0c685f Compare January 4, 2025 08:50
@github-actions github-actions bot added the test Related to test cases label Jan 4, 2025
@fundon fundon force-pushed the fundon/01_02_add_clipboard_native_extension branch 4 times, most recently from de72cb4 to 3472324 Compare January 6, 2025 11:30
@fundon fundon force-pushed the fundon/01_02_add_clipboard_native_extension branch from 3472324 to b32ff2c Compare January 6, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants