Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): rename doc to blocks #9510

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review January 3, 2025 09:37
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner January 3, 2025 09:37
Copy link
Contributor Author

Saul-Mirone commented Jan 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to rename all doc: Blocks -> blocks: Blocks, but this might be too much work.

@Saul-Mirone Saul-Mirone changed the base branch from 01-03-chore_editor_move_legacy_doc_collection_to_test_workspace to graphite-base/9510 January 3, 2025 09:40
@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_rename_doc_to_blocks branch from cc1f9db to f21c320 Compare January 3, 2025 09:54
@Saul-Mirone Saul-Mirone changed the base branch from graphite-base/9510 to canary January 3, 2025 09:55
@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_rename_doc_to_blocks branch from f21c320 to e203a8b Compare January 3, 2025 09:55
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.91%. Comparing base (2074bda) to head (4457cb7).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ne/shared/src/services/doc-display-meta-service.ts 0.00% 2 Missing ⚠️
...t-block/edgeless/components/frame/frame-preview.ts 0.00% 1 Missing ⚠️
...blocksuite/presets/_common/utils/markdown-utils.ts 0.00% 1 Missing ⚠️
...core/src/blocksuite/presets/ai/chat-panel/index.ts 0.00% 1 Missing ⚠️
...ntend/core/src/modules/workspace/impl/workspace.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9510      +/-   ##
==========================================
+ Coverage   52.85%   52.91%   +0.05%     
==========================================
  Files        2151     2151              
  Lines       96989    96989              
  Branches    16154    16154              
==========================================
+ Hits        51264    51322      +58     
+ Misses      44330    44300      -30     
+ Partials     1395     1367      -28     
Flag Coverage Δ
server-test 78.14% <ø> (+0.06%) ⬆️
unittest 32.49% <77.41%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_rename_doc_to_blocks branch from e203a8b to 5eb5224 Compare January 3, 2025 12:22
Copy link

graphite-app bot commented Jan 3, 2025

Merge activity

  • Jan 3, 7:48 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 3, 8:03 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test').
  • Jan 3, 8:14 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 3, 8:14 AM EST: A user merged this pull request with the Graphite merge queue.

@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_rename_doc_to_blocks branch from 5eb5224 to 4457cb7 Compare January 3, 2025 12:49
@graphite-app graphite-app bot merged commit 4457cb7 into canary Jan 3, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-03-refactor_editor_rename_doc_to_blocks branch January 3, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants