fix(vscode): Configuration default values use cloneDeep

tomjs · Jun 11, 2024 · 281ce50 · 281ce50
1 parent 6d42f94
commit 281ce50
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/packages/vscode/package.json b/packages/vscode/package.json
@@ -48,7 +48,11 @@
     "prepublishOnly": "pnpm build"
   },
   "dependencies": {
-    "@tomjs/node": "^2.1.0"
+    "@tomjs/node": "^2.1.0",
+    "lodash.clonedeep": "^4.5.0"
+  },
+  "devDependencies": {
+    "@types/lodash.clonedeep": "^4.5.9"
   },
   "peerDependencies": {
     "@types/vscode": "^1.56.0"

diff --git a/packages/vscode/src/configuration.ts b/packages/vscode/src/configuration.ts
@@ -1,3 +1,4 @@
+import cloneDeep from 'lodash.clonedeep';
 import { ConfigurationTarget, workspace } from 'vscode';
 
 export class Configuration<T> {
@@ -34,7 +35,7 @@ export class Configuration<T> {
     Object.keys(cfg)
       .filter(key => typeof cfg[key] !== 'function')
       .forEach(key => {
-        values[key] = cfg.get(key, this._defaultValues[key]);
+        values[key] = cfg.get(key) ?? cloneDeep(this._defaultValues[key]);
       });
     return values;
   }

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml