Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passed blarrg's cgb_sound tests, and other sound things 🔊 #286

Merged
merged 34 commits into from
Apr 27, 2019
Merged

Passed blarrg's cgb_sound tests, and other sound things 🔊 #286

merged 34 commits into from
Apr 27, 2019

Conversation

torch2424
Copy link
Owner

@torch2424 torch2424 commented Apr 24, 2019 •
edited
Loading

opens #197
opens #283

This was super hard. I was doing a lot of travelling in between, so I didn't have a lot of time to work on this. But for real, it was taking me like 6 hours per subtest. Sometimes, even subtests of the subtest. 😢 But I'm so glad these tests are over 😄

  • Makes the fixes to pass the tests.
  • Slightly fixes crackling mentioned in WasmBoy 1.0 GB/GBC Roadmap #197
  • Sets up the tests for the cgb_sound going forward 😄

Example in the README

cgb_sound golden

torch2424 added 30 commits March 3, 2019 01:10
@torch2424
Got registers in the blarrgg CGB test passing
e52c2f7
@torch2424
Passed blargg CGB Length tests
4f2b05a
@torch2424
Move the frame sequencer into it's own file, so that it can be used by
a6b72a0 
channels
@torch2424
Got through a lot of the trigger tests
14cc183
@torch2424
Fixed registers tests as well need to finish triggers
eb09607
@torch2424
Starting to solve isEnabeld to finally pass triggers
68cae36
@torch2424
Re-fixed isEnabledStatus
39006ef
@torch2424
Literally on the last trigger test for sound
f10a0fd
@torch2424
Left a note, and fixed debugger stepping
66fa5bd
@torch2424
Still stuck :(
7a250e7
@torch2424
Left another note
2baa971
@torch2424
Fixed frame sequencer being flipped, and fixed NR52 writing
29da834
@torch2424
Left a note to look at binjgb
8d09c96
@torch2424
FINALLY PASSED THE SOUND TRIGGER TEST!!!
fca25ce
@torch2424
Fixed channel 2 trigger
306c179
@torch2424
Passed all trigger tests
35ee438
@torch2424
Passes sweep #2
5820ffa
@torch2424
Passed more sweep tests
813116a
@torch2424
Soe updates still failing 5
3361a8d
@torch2424
Finally Passed the sweep subtest :D
a5b5d40
@torch2424
Passed sweep details
0cbfae8
@torch2424
Started fixing some things, and left notes for later
d86307a
@torch2424
Fixing up period timing
fe019ad
@torch2424
Fixed up negative periods on channels
c26362b
@torch2424
ONE LAST WAVE CHANNEL TEST!!!
1592fc5
@torch2424
FINISHED BLARGG CGB SOUND TEST!!!
8be6906
@torch2424
Updated all the tests
1972531
@torch2424
Added hotkeys to help
29aa78a
@torch2424
Logged out some buffers
7effe36
@torch2424
Moved around some more crackling debug logic
6289f51
@torch2424 torch2424 added the Core/Wasm Issues concerning the core library of Wasmboy label Apr 24, 2019
@torch2424 torch2424 self-assigned this Apr 24, 2019
@torch2424 torch2424 merged commit 06dee7a into master Apr 27, 2019
@torch2424 torch2424 deleted the sound-tests branch April 27, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@torch2424 torch2424

Labels
Core/Wasm Issues concerning the core library of Wasmboy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@torch2424