Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ext] fix: avoid repeated calls to initialize Home and Search Recommendations #1874

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[ext] fix: avoid repeated calls to initialize Home and Search Recommendations #1874

merged 1 commit into from
Jan 4, 2024

Conversation

amatissart
Copy link
Member

@amatissart amatissart commented Jan 4, 2024 •
edited
Loading

Description

This avoid to repeat API requests to fetch banners and recommendations when initializing the extension.

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@GresilleSiffle GresilleSiffle added Extension Development of the browser extension Bug Something isn't working labels Jan 4, 2024
@amatissart amatissart merged commit f3dd7f6 into main Jan 4, 2024
6 checks passed
@amatissart amatissart deleted the ext-fix-duplicate-requests branch January 4, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GresilleSiffle GresilleSiffle GresilleSiffle approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Extension Development of the browser extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amatissart @GresilleSiffle