Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatarコンポーネント追加(#6) #13

Merged
merged 5 commits into from
Jun 15, 2024
Merged

Avatarコンポーネント追加(#6) #13

merged 5 commits into from
Jun 15, 2024

Conversation

ZOI-dayo
Copy link
Contributor

丸い画像だけです

cp-20
cp-20 requested changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正お願いします...！

frontend/src/components/Avatar.vue Outdated Show resolved Hide resolved
frontend/src/components/Avatar.vue Outdated Show resolved Hide resolved
frontend/src/components/Avatar.vue Outdated Show resolved Hide resolved
@ZOI-dayo
Copy link
Contributor Author

あら、goのCodeQLのチェックが落ちている これフロントでは不要...?

cp-20
cp-20 requested changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

グッとよくなりました！　最後細かいですが1つだけお願いします...！

frontend/src/components/Avatar.vue Outdated Show resolved Hide resolved
@cp-20
Copy link
Contributor

cp-20 commented Jun 15, 2024

あら、goのCodeQLのチェックが落ちている これフロントでは不要...?

とりま無視しちゃってOK　@ikura-hamu 適当に見ておいてください

cp-20
cp-20 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう！　その調子でお願いします！

@cp-20 cp-20 merged commit d951e7c into main Jun 15, 2024
3 of 4 checks passed
@cp-20 cp-20 deleted the avatar_component branch June 15, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-20 cp-20 cp-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZOI-dayo @cp-20