Feat/suite core/e2e/convert unsupported browsers #16171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase this on the PW upgrade once it is merge and change the failing visual regression check to Aria snapshot |
Vere-Grey
force-pushed
the
feat/suite-core/e2e/convert-unsupported-browsers
branch
2 times, most recently
from
8ee0901 to
38ddb48
Compare
Unfortunatelly, PW does not support Firefox + Mobile combination It is also not recommended to run automation on outdated browsers
adds also firefox desktop test
also mask larger element for asset visual regression verification
Vere-Grey
force-pushed
the
feat/suite-core/e2e/convert-unsupported-browsers
branch
from
38ddb48 to
4bdc5ea
Compare
HajekOndrej
approved these changes
Jan 7, 2025
HajekOndrej
deleted the
feat/suite-core/e2e/convert-unsupported-browsers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts browser test to PW
Unfortunately PW does not support firefox - mobile combination and it is not recommended to run it with outdated browsers -> I had to remove 3 tests completely.
Enables again visual regression checks for web. The problematic market tests are disabled anyway and I added instruction how fix their visual comparison once we want them to run again.
Related Issue
Resolve 15606
Screenshots: