[AMD] Handling denorms in lowering math.sqrt and math.sqrt_rn #5422
+226
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we handled the denorm flushing behaviors of math.sqrt and math.sqrt_rn. They read HIP_FTZ to determine whether denorms should be preserved or flushed to zero.
math.sqrt
provides approximation of SQRT. In AMD backend, we usellvm.amdgcn.sqrt.f32
, which provides direct access tov_sqrt_f32
and has 1ULP accuracy.math.sqrt_rn
provides IEEE-compliant result(round-to-nearest-or-even) of SQRT. Following the implementation in LLVM, we use extra refinement to get correctly rounded result.New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD
.Select one of the following.
/test
forlit
tests/unittest
for C++ tests/python/test
for end-to-end testsFILL THIS IN
.Select one of the following.
lit
tests.lit
tests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)