[AMD] Flush denorms to zero in math.rsqrt #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modified the denorm handling behavior of math.rsqrt. In case of ftz, it calls llvm.amdgcn.rsq.f32 directly to flush the denormalized inputs to zero. Otherwise, it calls __ocml_rsqrt_f32, which will dynamically check the backend to decide ftz or not.
knwng
commented
Dec 16, 2024
| @@ -656,7 +656,7 @@ bool CTAPlanner::isElementwiseOp(Operation *op) const { | |||
| math::CtPopOp, math::ErfOp, math::ExpOp, math::Exp2Op, | |||
| math::FloorOp, math::ExpM1Op, math::FmaOp, math::LogOp, | |||
| math::Log10Op, math::Log1pOp, math::Log2Op, math::PowFOp, | |||
| math::RsqrtOp, math::SqrtOp, math::RsqrtOp, math::TanhOp>(op)) | |||
| math::SqrtOp, math::RsqrtOp, math::TanhOp>(op)) | |||
There was a problem hiding this comment.
Looks like it's duplicated. Please let me know if it's actually deliberate.
antiagainst
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modified the denorm handling behavior of math.rsqrt.
In case of ftz, it calls llvm.amdgcn.rsq.f32 directly to flush the denormalized inputs to zero. Otherwise, it calls __ocml_rsqrt_f32, which will dynamically check the backend to decide ftz or not.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)