Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverallsapp at v2 #40

Merged
merged 2 commits into from
Jan 4, 2024
Merged

coverallsapp at v2 #40

merged 2 commits into from
Jan 4, 2024

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Dec 18, 2023

No description provided.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f35544d) 98.85% compared to head (d96185b) 98.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          20       20           
  Lines        1838     1838           
=======================================
  Hits         1817     1817           
  Misses         21       21           
Flag Coverage Δ
unittests 98.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 98.857%. remained the same
when pulling f53bb7f on ranocha-patch-1
into ac6505b on main.

@ranocha
Copy link
Member Author

ranocha commented Jan 4, 2024

@andrewwinters5000 Up for a quick review? It would be nice to get a new release after merging #41 to update the online docs. Alternatively, you could push a special doc tag to build a new version of the online docs.

@andrewwinters5000
Copy link
Member

@andrewwinters5000 Up for a quick review? It would be nice to get a new release after merging #41 to update the online docs. Alternatively, you could push a special doc tag to build a new version of the online docs.

Sure, we can create a new release. What I will do first is double check the docs if there are any other discrepancies like the one caught in #41 . After that we should be good to go.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ranocha ranocha merged commit 465de99 into main Jan 4, 2024
8 checks passed
@ranocha ranocha deleted the ranocha-patch-1 branch January 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants