Removed deprecated keyword from plotting

[andrewwinters5000]

The keyword resolution has been deprecated in Makie and we now use the new suggested keyword size for all the Figure creation. Once this is merged I will release a new version.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (c55aa26) to head (c8fd6f8).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          20       20           
  Lines        1838     1838           
=======================================
  Hits         1817     1817           
  Misses         21       21           

Flag	Coverage Δ
unittests	98.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

coverage: 98.857%. remained the same
when pulling c8fd6f8 on arw-patch
into c55aa26 on main.

[ranocha]

Thanks. Do we need to update

HOHQMesh.jl/test/Project.toml

Line 8 in c55aa26

CairoMakie = "0.6, 0.7, 0.8"

as well?

[andrewwinters5000]

Thanks. Do we need to update

HOHQMesh.jl/test/Project.toml

Line 8 in c55aa26

CairoMakie = "0.6, 0.7, 0.8"

as well?

Good catch, yes we should update this. I will check the Makie page to see for which version this deprecation happened.

[andrewwinters5000]

So the deprecation happened with the release of Makie 0.20. I have yet to work out if this places a limit on the front end for GLMakie (for users) or CairoMakie (for testing).

[ranocha]

Thanks! We should finally use package extensions managing the compatibility correctly. But that should be done in another PR.

[andrewwinters5000]

Thanks! We should finally use package extensions managing the compatibility correctly. But that should be done in another PR.

Okay, this is related to creating a Downgrade.yml, right?

[ranocha]

It's related to it but independent of it. We use a proper package extension in Trixi.jl for the Makie plotting stuff

[andrewwinters5000]

Jaha, so basically something along the lines of this PR from Trixi? https://github.com/trixi-framework/Trixi.jl/pull/1494/files#diff-6058d487915aa254cfe1a5f8da6315b8c1fef4da04df38b0089a599803e28e5a

[ranocha]

Yes 👍