Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for P4est_jll to 2, (keep existing compat) #137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 4, 2024

This pull request changes the compat entry for the P4est_jll package from =2.8.1 to =2.8.1, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@sloede sloede force-pushed the compathelper/new_version/2024-12-04-00-15-24-157-03437682448 branch from d883f35 to 4d9986a Compare December 4, 2024 00:15
@JoshuaLampert
Copy link
Member

JuliaPackaging/Yggdrasil#9878 set the p4est version to v2.8.6 and enabled OpenMPI. The latter had the consequence that the current version of P4est_jll.jl is broken on Windows. JuliaPackaging/Yggdrasil#9911 should have fixed that by disabling OpenMPI again. However, CI failed, which (I guess) is the reason why no new P4est_jll.jl version has been registered after that PR. I don't know why CI failed. It was successful (after a restart) in the PR. Is there a way to rerun the Yggdrasil pipeline for the PR JuliaPackaging/Yggdrasil#9911, which hopefully succeeds, such that P4est_jll.jl gets updated? Once we managed that and CI is successful again here, we can consider setting the compat bound as P4est_jll = "=2.8.6". This should also close #76. I am not sure though whether the issues discussed in #76 are addressed, such that we are ready to update the p4est version.

@sloede
Copy link
Member

sloede commented Dec 4, 2024

Is there a way to rerun the Yggdrasil pipeline for the PR JuliaPackaging/Yggdrasil#9911, which hopefully succeeds, such that P4est_jll.jl gets updated?

Best to ping Mosè Giordano about this either in the Yggdrasil PR or the #binarybuilder channel in the Julia Slack.

@ranocha
Copy link
Member

ranocha commented Dec 5, 2024

Please also note #76 and the discussions linked there

Project.toml Outdated Show resolved Hide resolved
@JoshuaLampert
Copy link
Member

Tests are still failing on Windows with P4est_jll.jl@2.8.7 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants