Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for TimerOutputs #31

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix tests for TimerOutputs #31

merged 1 commit into from
Oct 10, 2024

Conversation

efaulhaber
Copy link
Member

KristofferC/TimerOutputs.jl#167 removed leading spaces in the timer outputs causing our tests to fail.
I also now require the latest version to make sure that tests pass.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (033a96f) to head (a7016ae).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files           5        5           
  Lines          80       80           
=======================================
  Hits           76       76           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber requested a review from sloede October 9, 2024 08:28
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit 9d5899d into main Oct 10, 2024
15 checks passed
@ranocha ranocha deleted the fix-timer-tests branch October 10, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants