Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize surface normal calc #539
base: main
Are you sure you want to change the base?
Generalize surface normal calc #539
Changes from 221 commits
f90f017
372d67c
f564478
9c9e182
90897f6
1df6912
6449b5f
439210f
b31640f
675c030
2b0b09c
b812869
c3884d7
45938eb
3bdfc20
de4f0e8
c49dd87
780cee3
7550c3d
87c21b9
9cab05f
896faef
b567c55
3de9a75
06a1223
31d4404
a95a54a
ce74643
17da7ef
f002d2b
120eb80
31208ad
81591ad
066f967
df6e1ac
b58fbca
df44891
bd8cd98
23d72d8
82d6b71
3338a3f
eae775c
53e6afd
75983ac
3aec5c6
651790c
f721ac2
e4b9a75
66f2a03
d4893fb
e95151d
8c8a3cc
4bd3c22
79fac64
af7c748
ccde44a
dd53390
7e504a9
2d230bf
d0d6408
6ddd51c
dbfc4db
35a3e3e
43b45f4
a5e3ab1
4e2059d
08c662e
a9a5b98
6060b04
fb762b9
9685cdb
a6892f4
f598b98
d2303ec
bb68e90
1fbc7cb
5a59211
451e1e6
755e768
aaf3bd9
f50d436
493c6ea
c0c1227
8031c01
f9dfe29
14c7999
a00f254
367f2fa
e9be23a
4626383
03618b9
6a5f5ad
ab72434
a4e3d92
fc6432f
f5c59dd
702e833
89af7de
3e0ca33
050e42d
67630d6
2f25b28
d0c5d2d
069be49
4ba6e9c
15a3446
56678f4
b8c4d89
0409873
ed1fca0
414adcf
cde0fa5
7d778a7
fd523fc
cc992b6
707c4ab
70ff163
4d1062f
5a26313
760eddb
5c40040
624d66f
1692242
3c0f684
c8cd876
a197fbe
78e99e1
dfbcf2b
51c2ec0
8f78cd4
a795fbc
b6a62d7
63535a6
7a2d704
63537a6
7bbb3a5
ff84aea
7aa1e84
06976eb
341886d
61e3325
c53246d
6bc5567
c017b45
6de5f70
3a083a6
f759fb3
1c5d0aa
54dc3ed
0326b98
dbb9d75
643dfa8
50dc742
7a77c11
1969525
ed83ea1
5142d13
493e26b
1c1cd58
612fd43
35b7c4a
3733c21
e1fc1bb
04595af
7b91e09
0acdcc5
d14fd19
bb12fb8
f84cafa
7cbfd72
528c2fd
a4381aa
eab774a
31b2f75
1d05304
4ed0b91
1ce0460
1774f5a
4daf984
ac2eb2c
258f2ba
1a9f3f5
8946b45
ddfab3e
76e5354
e079dc0
b4c5ace
0b3043c
3335386
7d4016c
c47850b
d5e7c63
514ffcf
223bcd0
d9227bb
3c5fd08
969dedd
c6371eb
4bf25e6
ebf6602
8659850
5b0ed25
7a6331e
3c80adf
d09b163
593c746
ba69a80
67d5b87
f276a7b
b17a629
537df19
20b77d7
d7b6af1
01bddb0
dc6fa70
ffc83d3
e424cfa
041861e
21f08b2
0b63bca
b7f448c
f4fbbb3
589d416
1263e1a
dd56f47
306f96d
93630aa
9f758be
cd26885
80e51ba
4721aec
98a5f6c
e05edea
36741d7
ba8765f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to wait for #529 before we release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on how long that still will take...