-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add 1D multilayer shallow water equations #30
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 99.38% 99.22% -0.16%
==========================================
Files 40 45 +5
Lines 1459 1680 +221
==========================================
+ Hits 1450 1667 +217
- Misses 9 13 +4 ☔ View full report in Codecov by Sentry. |
These results all seem reasonable. Are these all with the EC scheme? It is a bit strange that the h1 and h1v tend to converge with |
Yes, all the results were obtained with the EC flux. The trend remains roughly the same when I test with In most cases it seems that convergence for layer 2 is better than for layers 1 & 3 (even above the expected convergence order), but I don't have an explanation why that is. |
It is quite strange that the "sandwiched" layer converges with slightly higher order than the other layers. It is also weird that the convergence of h2_v and h3_v are both higher than expected because you are setting the velocities to be constants. So I would assume that the convergence behavior of h3_v would match that of h (for instance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @patrickersing ! It is very cool that we can have an entropy stable scheme on an arbitrary number of layers. This abstraction should also make it easier to do the mullti-layer wetting and drying. I left a few comments and questions.
examples/tree_1d_dgsem/elixir_shallowwater_multilayer_well_balanced.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Although I still cannot work out why some functions are not reported as covered when they should be.
This PR will add the 1D multilayer shallow water equations, which are a generalization of the currently implemented two-layer shallow water equations for an arbitrary amount of layers. The implementation employs a specific formulation of the system with a nonconservative pressure term.
The implementation is done similar to the multicomponent equations in
Trixi.jl
with some modifications, to account for the layer-wise structure.Additional tests:
Additional functionality:
lake_at_rest_error
,energy_total
, etc.)