Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main julia version for PackageCompiler #216

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Nov 19, 2024

This fixes the long lasting package compiler issue. Not because of julia versions, but because of a new package compiler release. In particular this PR JuliaLang/PackageCompiler.jl#987 and this line https://github.com/JuliaLang/PackageCompiler.jl/pull/987/files#diff-ec15186e80d0dd77de71866cee17c75857c4eb441c51df407b96f680c11cf847 seem relevant.

However, I noticed that the resulting shared object is now large (~700 MB) regardless of whether filter_stdlibs is set to true or false.

If we merge this and thereby drop julia 1.9, this resolves #152 #213

@benegee benegee enabled auto-merge (squash) November 19, 2024 09:20
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (0e328c1) to head (81fb07b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files          21       21           
  Lines         877      877           
  Branches       52       52           
=======================================
  Hits          736      736           
  Misses        137      137           
  Partials        4        4           
Flag Coverage Δ
unittests 83.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@benegee benegee disabled auto-merge November 19, 2024 09:40
@benegee benegee merged commit 07845ab into main Nov 19, 2024
7 checks passed
@benegee benegee deleted the bg/julia-110-for-pc branch November 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia's Pkg currently does not work in CI workflow
2 participants