Skip to content

Commit

Permalink
Technical/Update gem dependencies (#170)
Browse files Browse the repository at this point in the history
* Removed faker development dependency
* Updated gem development dependencies
* Updated gem version, changelog
  • Loading branch information
bestwebua authored Aug 11, 2021
1 parent 98e9379 commit e47bf19
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 29 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.4.8] - 2021.08.12

### Updated

- Updated gem development dependencies
- Updated gem version

### Changed

- `faker` to `ffaker` development dependency

## [2.4.7] - 2021.08.09

### Updated
Expand Down
20 changes: 8 additions & 12 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
truemail (2.4.7)
truemail (2.4.8)
simpleidn (~> 0.2.1)

GEM
Expand All @@ -17,21 +17,17 @@ GEM
childprocess (4.1.0)
coderay (1.1.3)
colorize (0.8.1)
concurrent-ruby (1.1.9)
crack (0.4.5)
rexml
diff-lcs (1.4.4)
dns_mock (1.4.0)
simpleidn (~> 0.2.1)
docile (1.4.0)
faker (2.18.0)
i18n (>= 1.6, < 2)
fasterer (0.9.0)
colorize (~> 0.7)
ruby_parser (>= 3.14.1)
ffaker (2.18.0)
hashdiff (1.0.1)
i18n (1.8.10)
concurrent-ruby (~> 1.0)
iniparse (1.5.0)
json (2.5.1)
json_matchers (0.11.1)
Expand All @@ -52,7 +48,7 @@ GEM
pry-byebug (3.9.0)
byebug (~> 11.0)
pry (~> 0.13.0)
psych (3.3.2)
psych (4.0.1)
public_suffix (4.0.6)
rainbow (3.0.0)
rake (13.0.6)
Expand Down Expand Up @@ -85,7 +81,7 @@ GEM
rubocop-ast (>= 1.8.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.9.0)
rubocop-ast (1.9.1)
parser (>= 3.0.1.1)
rubocop-performance (1.11.4)
rubocop (>= 1.7.0, < 2.0)
Expand All @@ -105,8 +101,8 @@ GEM
simpleidn (0.2.1)
unf (~> 0.1.4)
thor (1.1.0)
truemail-rspec (0.6.0)
faker (~> 2.17)
truemail-rspec (0.7.0)
ffaker (~> 2.18)
rspec (~> 3.10)
truemail (>= 2.4)
unf (0.1.4)
Expand All @@ -125,8 +121,8 @@ DEPENDENCIES
bundler (~> 2.2, >= 2.2.25)
bundler-audit (~> 0.8.0)
dns_mock (~> 1.4)
faker (~> 2.18)
fasterer (~> 0.9.0)
ffaker (~> 2.18)
json_matchers (~> 0.11.1)
overcommit (~> 0.58.0)
pry-byebug (~> 3.9)
Expand All @@ -138,7 +134,7 @@ DEPENDENCIES
rubocop-rspec (~> 2.4)
simplecov (~> 0.17.1)
truemail!
truemail-rspec (~> 0.6)
truemail-rspec (~> 0.7.0)
webmock (~> 3.14)

BUNDLED WITH
Expand Down
2 changes: 1 addition & 1 deletion lib/truemail/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Truemail
VERSION = '2.4.7'
VERSION = '2.4.8'
end
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# frozen_string_literal: true

require 'faker'
require 'ffaker'
14 changes: 7 additions & 7 deletions spec/support/helpers/context_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ module ContextHelper
NON_ASCII_WORDS = %w[mañana ĉapelo dấu παράδειγμα 屋企].freeze

def random_email
faker.email
ffaker.email
end

def random_internationalized_email
"#{faker.username}@#{Truemail::ContextHelper::NON_ASCII_WORDS.sample}.#{faker.domain_suffix}"
"#{ffaker.user_name}@#{Truemail::ContextHelper::NON_ASCII_WORDS.sample}.#{ffaker.domain_suffix}"
end

def random_ip_address
faker.ip_v4_address
ffaker.ip_v4_address
end

def random_domain_name
faker.domain_name
ffaker.domain_name
end

def random_uniq_domain_name
faker.unique.domain_name
ffaker.unique.domain_name
end

def rdns_lookup_host_address(host_address)
Expand All @@ -38,8 +38,8 @@ def email_punycode_domain(email)

private

def faker
Faker::Internet
def ffaker
FFaker::Internet
end
end
end
12 changes: 6 additions & 6 deletions spec/support/helpers/context_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@

describe '#random_email' do
specify do
expect(Faker::Internet).to receive(:email).and_call_original
expect(FFaker::Internet).to receive(:email).and_call_original
expect(random_email).to match(Truemail::RegexConstant::REGEX_EMAIL_PATTERN)
end
end

describe '#random_domain_name' do
specify do
expect(Faker::Internet).to receive(:domain_name).and_call_original
expect(FFaker::Internet).to receive(:domain_name).and_call_original
expect(random_domain_name).to match(Truemail::RegexConstant::REGEX_DOMAIN_PATTERN)
end
end

describe '#random_uniq_domain_name' do
specify do
expect(Faker::Internet).to receive_message_chain(:unique, :domain_name)
expect(FFaker::Internet).to receive_message_chain(:unique, :domain_name)
random_uniq_domain_name
end

Expand All @@ -30,7 +30,7 @@

describe '#random_ip_address' do
specify do
expect(Faker::Internet).to receive(:ip_v4_address).and_call_original
expect(FFaker::Internet).to receive(:ip_v4_address).and_call_original
expect(random_ip_address).to match(Truemail::RegexConstant::REGEX_DNS_SERVER_ADDRESS_PATTERN)
end
end
Expand Down Expand Up @@ -62,8 +62,8 @@

specify do
stub_const("#{described_class}::NON_ASCII_WORDS", [ascii_word])
expect(Faker::Internet).to receive(:username).and_return(user)
expect(Faker::Internet).to receive(:domain_suffix).and_return(domain_zone)
expect(FFaker::Internet).to receive(:user_name).and_return(user)
expect(FFaker::Internet).to receive(:domain_suffix).and_return(domain_zone)
expect(random_internationalized_email).to eq("#{user}@#{ascii_word}.#{domain_zone}")
end
end
Expand Down
4 changes: 2 additions & 2 deletions truemail.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.25'
spec.add_development_dependency 'bundler-audit', '~> 0.8.0'
spec.add_development_dependency 'dns_mock', '~> 1.4'
spec.add_development_dependency 'faker', '~> 2.18'
spec.add_development_dependency 'fasterer', '~> 0.9.0'
spec.add_development_dependency 'ffaker', '~> 2.18'
spec.add_development_dependency 'json_matchers', '~> 0.11.1'
spec.add_development_dependency 'overcommit', '~> 0.58.0'
spec.add_development_dependency 'pry-byebug', '~> 3.9'
Expand All @@ -48,6 +48,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.4'
spec.add_development_dependency 'rubocop-rspec', '~> 2.4'
spec.add_development_dependency 'simplecov', '~> 0.17.1'
spec.add_development_dependency 'truemail-rspec', '~> 0.6'
spec.add_development_dependency 'truemail-rspec', '~> 0.7.0'
spec.add_development_dependency 'webmock', '~> 3.14'
end

0 comments on commit e47bf19

Please sign in to comment.