First draft for GitLab CE app #1252
Open
+7,443
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft of an app for GitLab Community Edition. I can run: .github/scripts/ci.py --app gitlab-ce --train community --test-file basic-values.yaml successfully. I can also run the result docker-compose.yaml file manually and interact with the service. I believe I have all of the weirdness knocked out, but it's been a game of whack-a-mole, rather than first-principles. TODO: it could use a bit of instructional information about e.g. changing the initial root password and/or working with the gitlab.rb file. The app has taken ownership of the `GITLAB_OMNIBUS_CONFIG` environment variable, it might be nice to let users append their own bits to it. I'd appreciate any feedback on the app.
I failed to clean up all of the bits in the questions.yaml file when I stole it from another app. This fixes those bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of an app for GitLab Community Edition.
I can run:
.github/scripts/ci.py --app gitlab-ce --train community --test-file basic-values.yaml
successfully.
I can also run the result docker-compose.yaml file manually and interact with the service.
I believe I have all of the weirdness knocked out, but it's been a game of whack-a-mole, rather than first-principles.
TODO: it could use a bit of instructional information about e.g. changing the initial root password and/or working with the gitlab.rb file. The app has taken ownership of the
GITLAB_OMNIBUS_CONFIGenvironment variable, it might be nice to let users append their own bits to it.I'd appreciate any feedback on the app.