Fix crash when generating SMB configuration on standby

truenas · Dec 24, 2024 · a34502d · a34502d
1 parent 617f2b4
commit a34502d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/middlewared/middlewared/etc_files/local/smb4.conf.mako b/src/middlewared/middlewared/etc_files/local/smb4.conf.mako
@@ -2,7 +2,7 @@
 # SMB.CONF(5)		The configuration file for the Samba suite 
 #
 <%
-   shares = render_ctx['smb.generate_smb_configuration'].pop('SHARES')
+   shares = render_ctx['smb.generate_smb_configuration'].pop('SHARES', [])
 %>
 
 [global]

diff --git a/src/middlewared/middlewared/plugins/smb.py b/src/middlewared/middlewared/plugins/smb.py
@@ -127,7 +127,7 @@ async def unixcharset_choices(self):
     @private
     def generate_smb_configuration(self):
         if self.middleware.call_sync('failover.status') not in ('SINGLE', 'MASTER'):
-            return {'netbiosname': 'TN_STANDBY'}
+            return {'netbiosname': 'TN_STANDBY', 'SHARES': []}
 
         if (ds_type := self.middleware.call_sync('directoryservices.status')['type']) is not None:
             ds_type = DSType(ds_type)