NAS-131559 / 25.04 / Remove accepts style decorator from apps plugin #15225
Conversation
bugclerk
changed the title
| pass | ||
|
|
||
|
|
||
| class AppContainerIDResult(BaseModel): |
There was a problem hiding this comment.
We should try and keep Args and Result model pairs together.
There was a problem hiding this comment.
Yes and that is indeed my intention but then for the result model we need to have another base model which is what is in between the args/result model. If we keep the args/result together then the models which are only used for these 2 will have to live some where else and it looked messy to me that way. So for example here is what i am proposing:
Args model
Some models required for result if any
Result model
There was a problem hiding this comment.
It does get hairy with lots of extra models so I can see where you're coming from. The NEP proposes this structure:
Entry model (if applicable)
All extra models
Args and Result pairs in alphabetical order
Granted, this does separate Args/Result models from their relevant helper models so I don't want to be the style police on this one.
|
This PR has been merged and conversations have been locked. |
Context
Removes accept style decorator from app plugin.