NAS-131762 / 25.04 / Add private NFS method to clear rmtab or selected entries. #15276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper bash script to be used in systemd NFS startup. Add pre-start call to helper script in systemd NFS server override.
bugclerk
changed the title
|
We're trying to avoid adding more scripts where we call into private middleware methods. This should be part of middleware startup and not a systemd unit. |
Make call to clear rmtab from nfs.setup_directories. Cannot use middleware setup hook because /var/db/system/nfs is not yet available at that point.
anodos325
approved these changes
Dec 31, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmtab catch-22
NFSv3 uses
rmtabto list the NFSv3 clients that have mounted a share. An entry is added when mountd successfully processes a client mount command. The client entries are removed only when the client unmounts the share via theumountcommand. If the client is powered off or stops using the share for any reason without first sending theumountcommand thermtabentry for that client will remain. Forever. This results in the accumulation of many stale entries inrmtab. There is no 'optimal' solution to address this. Two possible options are to manually delete the known stale entries or clearrmtabon system boot. Manually clearing selected entries is successful only with apriori knowledge of which clients are not returning. Clearingrmtabon boot will clear stale entries and entries associated with active clients. The 'active' clients do not automatically repopulatermtab.NFSv4 does not have the same issue as it is a connection based protocol and maintains the NFSv4 client list in an active manner.
No CI test was created as it requires rebooting the server under test.
Manual failover testing found rmtab is not cleared (correct behavior).
With this change a reboot or middleware restart will clear rmtab.