Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133313 / 25.04 / Safely normalize host ports when retrieving from docker #15279

Merged
merged 1 commit into from
Dec 31, 2024
Merged

NAS-133313 / 25.04 / Safely normalize host ports when retrieving from docker #15279

merged 1 commit into from
Dec 31, 2024

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Dec 30, 2024

No description provided.

@sonicaj sonicaj added the jira label Dec 30, 2024
@sonicaj sonicaj requested a review from a team December 30, 2024 16:14
@sonicaj sonicaj self-assigned this Dec 30, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133313

@bugclerk bugclerk changed the title Safely normalize host ports when retrieving from docker NAS-133313 / 25.04 / Safely normalize host ports when retrieving from docker Dec 30, 2024
@sonicaj sonicaj force-pushed the safely-get-hostport branch from 2d4bd4a to b38f169 Compare December 30, 2024 16:20
@sonicaj sonicaj requested a review from yocalebo December 30, 2024 16:20
yocalebo
yocalebo approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@truenas truenas deleted a comment from bugclerk Dec 30, 2024
@sonicaj sonicaj merged commit d6bd38e into master Dec 31, 2024
2 checks passed
@sonicaj sonicaj deleted the safely-get-hostport branch December 31, 2024 10:12
@bugclerk bugclerk mentioned this pull request Dec 31, 2024
Merged
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

Assignees

@sonicaj sonicaj

Labels
backport-24.10.2 backported jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonicaj @bugclerk @yocalebo