-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133326 / 25.04 / Add enterprise license check for virt plugin #15286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira label ignored, branch name already named after an existing ticket. |
bugclerk
changed the title
Add enterprise license check for virt plugin
NAS-133326 / 25.04 / Add enterprise license check for virt plugin
Dec 31, 2024
1 similar comment
yocalebo
reviewed
Dec 31, 2024
Qubad786
force-pushed
the
NAS-132723
branch
2 times, most recently
from
January 2, 2025 15:06
00d669b
to
7f9c5fc
Compare
Qubad786
force-pushed
the
NAS-132723
branch
2 times, most recently
from
January 2, 2025 16:00
da3e409
to
2609ec8
Compare
yocalebo
reviewed
Jan 2, 2025
yocalebo
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to have a license check in place to not let enterprise consumers consume virt plugin if they are not licensed for it.