Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133326 / 25.04 / Add enterprise license check for virt plugin #15286

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Qubad786
Copy link
Contributor

Context

We need to have a license check in place to not let enterprise consumers consume virt plugin if they are not licensed for it.

@Qubad786 Qubad786 added the jira label Dec 31, 2024
@Qubad786 Qubad786 requested a review from a team December 31, 2024 10:30
@bugclerk
Copy link
Contributor

Jira label ignored, branch name already named after an existing ticket.

@bugclerk bugclerk changed the title Add enterprise license check for virt plugin NAS-133326 / 25.04 / Add enterprise license check for virt plugin Dec 31, 2024
@bugclerk
Copy link
Contributor

1 similar comment
@bugclerk
Copy link
Contributor

@Qubad786 Qubad786 force-pushed the NAS-132723 branch 2 times, most recently from 00d669b to 7f9c5fc Compare January 2, 2025 15:06
@Qubad786 Qubad786 requested a review from yocalebo January 2, 2025 15:09
@Qubad786 Qubad786 force-pushed the NAS-132723 branch 2 times, most recently from da3e409 to 2609ec8 Compare January 2, 2025 16:00
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Qubad786 Qubad786 merged commit 7f6a681 into master Jan 2, 2025
2 checks passed
@Qubad786 Qubad786 deleted the NAS-132723 branch January 2, 2025 16:41
@bugclerk
Copy link
Contributor

bugclerk commented Jan 2, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants