Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133056 / 25.04 / Allow not retrieving user props for datasets #15287

Merged
merged 1 commit into from
Jan 2, 2025
Merged

NAS-133056 / 25.04 / Allow not retrieving user props for datasets #15287

merged 1 commit into from
Jan 2, 2025

Conversation

Qubad786
Copy link
Contributor

Context

There is no way currently to not retrieve user properties when retrieving dataset details from pool.dataset namespace, hence changes have been added to make that configurable.

@Qubad786 Qubad786 requested a review from a team December 31, 2024 11:08
@bugclerk bugclerk changed the title Allow not retrieving user props for datasets NAS-133056 / 25.04 / Allow not retrieving user props for datasets Dec 31, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133056

yocalebo
yocalebo reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can write a trivial test for this

creatorcary
creatorcary approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@creatorcary creatorcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Qubad786 Qubad786 requested a review from yocalebo January 1, 2025 16:07
@Qubad786 Qubad786 requested a review from yocalebo January 1, 2025 20:12
@Qubad786 Qubad786 merged commit 41a71c6 into master Jan 2, 2025
2 checks passed
@Qubad786 Qubad786 deleted the NAS-133056 branch January 2, 2025 15:01
@bugclerk
Copy link
Contributor

bugclerk commented Jan 2, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creatorcary creatorcary creatorcary approved these changes

@yocalebo yocalebo yocalebo approved these changes

Assignees
No one assigned
Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Qubad786 @bugclerk @yocalebo @creatorcary