Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133364 / 25.04 / Improve keytab validation #15297

Merged
merged 2 commits into from
Jan 2, 2025
Merged

NAS-133364 / 25.04 / Improve keytab validation #15297

merged 2 commits into from
Jan 2, 2025

Conversation

anodos325
Copy link
Contributor

  • Apply schema to validation error message
  • Prevent empty string
  • Properly check that file provides at least one keytab entry

@bugclerk bugclerk changed the title Improve keytab validation NAS-133364 / 25.04 / Improve keytab validation Jan 2, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Jan 2, 2025

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133364

@anodos325 anodos325 requested a review from a team January 2, 2025 16:41
@anodos325
Improve keytab validation
ad5ca97 
* Apply schema to validation error message
* Prevent empty string
* Properly check that file provides at least one keytab entry
mgrimesix
mgrimesix approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@mgrimesix mgrimesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flake8 issues only (that I can see).

src/middlewared/middlewared/plugins/kerberos.py Outdated Show resolved Hide resolved
src/middlewared/middlewared/plugins/kerberos.py Outdated Show resolved Hide resolved
@anodos325 anodos325 merged commit e9fcf54 into master Jan 2, 2025
2 checks passed
@anodos325 anodos325 deleted the NAS-133364 branch January 2, 2025 17:36
@bugclerk bugclerk mentioned this pull request Jan 2, 2025
Merged
@bugclerk
Copy link
Contributor

bugclerk commented Jan 2, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgrimesix mgrimesix mgrimesix approved these changes

Assignees
No one assigned
Labels
backport-24.10.2 backported no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anodos325 @bugclerk @mgrimesix