Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes from post to get #30

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: changes from post to get #30

merged 1 commit into from
Oct 8, 2024

Conversation

helio-frota
Copy link
Contributor

@helio-frota helio-frota commented Oct 8, 2024 •
edited
Loading

  • Currently graphql endpoints accepts only GET method

Closes #29

it works at least:

2024-10-08T13:55:04.185054Z  INFO ThreadId(24) actix_web::middleware::logger: ::1 "GET /graphql?query=%7B%22query%22%3A%20%22%7BgetAdvisories%20%7B%20id%20sha256%20published%20organization%20%7B%20id%20website%20%7D%20vulnerabilities%20%7B%20id%20title%20%7D%7D%7D%22%20%7D HTTP/1.1" 200 687 "-" "goose/0.17.3-dev" 0.005461
2024-10-08T13:55:11.331627Z  INFO ThreadId(25) actix_web::middleware::logger: ::1 "GET /graphql?query=%7B%22query%22%3A%20%22%7BgetAdvisories%20%7B%20id%20sha256%20published%20organization%20%7B%20id%20website%20%7D%20vulnerabilities%20%7B%20id%20title%20%7D%7D%7D%22%20%7D HTTP/1.1" 200 687 "-" "goose/0.17.3-dev" 0.005915
2024-10-08T13:55:18.490982Z  INFO ThreadId(26) actix_web::middleware::logger: ::1 "GET /graphql?query=%7B%22query%22%3A%20%22%7BgetAdvisories%20%7B%20id%20sha256%20published%20organization%20%7B%20id%20website%20%7D%20vulnerabilities%20%7B%20id%20title%20%7D%7D%7D%22%20%7D HTTP/1.1" 200 687 "-" "goose/0.17.3-dev" 0.005733
2024-10-08T13:55:22.442870Z  INFO ThreadId(27) actix_web::middleware::logger: ::1 "GET /graphql?query=%7B%22query%22%3A%20%22%7BgetAdvisories%20%7B%20id%20sha256%20published%20organization%20%7B%20id%20website%20%7D%20vulnerabilities%20%7B%20id%20title%20%7D%7D%7D%22%20%7D HTTP/1.1" 200 687 "-" "goose/0.17.3-dev" 0.005442

@helio-frota
fix: changes from post to get
eb5bfa0 
* Currently graphql endpoints accepts only GET method
JimFuller-RedHat
JimFuller-RedHat approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have a question about motivation for this change, otherwise LGTM

@helio-frota helio-frota merged commit 8033d27 into trustification:main Oct 8, 2024
1 check passed
@helio-frota helio-frota deleted the query branch October 8, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimFuller-RedHat JimFuller-RedHat JimFuller-RedHat approved these changes

@ctron ctron Awaiting requested review from ctron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting 405 when trying to hit graphql endpoint
2 participants
@helio-frota @JimFuller-RedHat