Adds extra env var for memory prof #33
Conversation
helio-frota
force-pushed
the
mem-prof-graphql
branch
from
3de46b3 to
c61ca73
Compare
* That extra env var is for a specific case with graphql and no auth * Adds remaining tests * Adds step by step doc
helio-frota
force-pushed
the
mem-prof-graphql
branch
from
c61ca73 to
2d0ebb0
Compare
| .execute() | ||
| .await?; | ||
|
|
||
| if !mem_prof { |
There was a problem hiding this comment.
Is there a reason why we need to do this here ?
There was a problem hiding this comment.
if this is about turning on or off auth, because for some reason it interferes with memory profiling why not switch it there ?
There was a problem hiding this comment.
thanks for the review
because I'm avoiding the required env_vars
let issuer_url = std::env::var("ISSUER_URL").context("Missing env-var 'ISSUER_URL'")?;
let client_id = std::env::var("CLIENT_ID").context("Missing env-var 'CLIENT_ID'")?;
let client_secret = std::env::var("CLIENT_SECRET").context("Missing env-var 'CLIENT_SECRET'")?;
and avoiding to hit this .register_transaction(custom_client.clone().set_name("logon"))
| } | ||
|
|
||
| pub async fn g_get_advisory_by_id(user: &mut GooseUser) -> TransactionResult { | ||
| let body = r#"{ "query": "{ getAdvisoryById(id: \"37292820-00ee-4299-8097-a11f8348bdf8\") { id title }}" }"#; |
There was a problem hiding this comment.
Is this intentionally a negative test eg. I would have thought uuid are not guaranteed ?
There was a problem hiding this comment.
I see your point here, but I'm assuming the dump.sql content will continue the same as we have a step-by-step doc for this.
| @@ -0,0 +1,57 @@ | |||
| # graphql memory profiling with heaptrack and disabled auth | |||
There was a problem hiding this comment.
is this not memory profiling for everything ... why specific instructions for graphql ?
There was a problem hiding this comment.
is this not memory profiling for everything
that's correct 👍
why specific instructions for graphql ?
This test was to help with this investigation only trustification/trustify#750
There was a problem hiding this comment.
I start to agree that we are not required to land the PR.. Adding a test for something that tends to be transient
I'm thinking in a way to have a handy graphql-specific-mem-prof-only.
🤔 even if we close the PR the register will continue here so we can replicate
Closes #31