Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deleting multiple databases with turso db destroy #669

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Support deleting multiple databases with turso db destroy #669

merged 10 commits into from
Oct 5, 2023

Conversation

phenpessoa
Copy link
Contributor

First time contributing to the repo, sorry if I'm doing something wrong, couldn't find a contributions guideline.

fixes #667

@phenpessoa phenpessoa temporarily deployed to external September 29, 2023 18:46 — with GitHub Actions Inactive
@penberg
Copy link
Contributor

penberg commented Oct 5, 2023

Thanks @phenpessoa! @athoscouto @gris @avinassh, can you folks please review?

@athoscouto athoscouto self-requested a review October 5, 2023 12:54
@athoscouto athoscouto self-assigned this Oct 5, 2023
athoscouto
athoscouto requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@athoscouto athoscouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Made some comments. The spinner one is the most critical, so we'll need that fixed before moving forward. Let me know if you have any questions.

internal/cmd/utils.go Outdated Show resolved Hide resolved
internal/cmd/db_destroy.go Outdated Show resolved Hide resolved
internal/cmd/db_destroy.go Outdated Show resolved Hide resolved
@phenpessoa
Copy link
Contributor Author

@athoscouto pushed the requested changes

@phenpessoa phenpessoa temporarily deployed to external October 5, 2023 19:03 — with GitHub Actions Inactive
athoscouto
athoscouto approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@athoscouto athoscouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/cmd/utils.go Outdated Show resolved Hide resolved
internal/cmd/utils.go Outdated Show resolved Hide resolved
internal/cmd/db_destroy.go Show resolved Hide resolved
@phenpessoa phenpessoa temporarily deployed to external October 5, 2023 19:47 — with GitHub Actions Inactive
@athoscouto athoscouto merged commit 5332372 into tursodatabase:main Oct 5, 2023
2 checks passed
@phenpessoa phenpessoa deleted the destroy-multiple branch October 5, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athoscouto athoscouto athoscouto approved these changes

Assignees

@athoscouto athoscouto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deleting multiple databases with turso db destroy
3 participants
@phenpessoa @penberg @athoscouto