-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shrinked horizontal separator #9192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR fixes styling issues with the HorizontalSeparator component by preventing unwanted shrinking and simplifying its usage across authentication forms.
- Added
flex-shrink: 0
toStyledSeparator
inpackages/twenty-ui/src/display/text/components/HorizontalSeparator.tsx
to maintain proper width - Removed redundant
visible
prop usage in sign-in/up forms since it defaults to true - Reordered imports in
SettingsSSOSAMLForm.tsx
to follow internal-first convention
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
{authProviders.google && <SignInUpWithGoogle />} | ||
|
||
{authProviders.microsoft && <SignInUpWithMicrosoft />} | ||
<HorizontalSeparator visible /> | ||
<HorizontalSeparator /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: consider conditionally rendering the separator only when both social providers and password form are present, similar to SignInUpWorkspaceScopeForm
0551a73
to
afc5678
Compare
Log
|
Related issue: https://discord.com/channels/1130383047699738754/1317185369577492532/1317185369577492532.
TL;DR: When used in a flex container, the separators gets hidden when the container becomes scrollable. We must ensure they can't shrink.