Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shrinked horizontal separator #9192

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

Devessier
Copy link
Contributor

@Devessier Devessier commented Dec 23, 2024

Related issue: https://discord.com/channels/1130383047699738754/1317185369577492532/1317185369577492532.

TL;DR: When used in a flex container, the separators gets hidden when the container becomes scrollable. We must ensure they can't shrink.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes styling issues with the HorizontalSeparator component by preventing unwanted shrinking and simplifying its usage across authentication forms.

  • Added flex-shrink: 0 to StyledSeparator in packages/twenty-ui/src/display/text/components/HorizontalSeparator.tsx to maintain proper width
  • Removed redundant visible prop usage in sign-in/up forms since it defaults to true
  • Reordered imports in SettingsSSOSAMLForm.tsx to follow internal-first convention

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 109 to 112
{authProviders.google && <SignInUpWithGoogle />}

{authProviders.microsoft && <SignInUpWithMicrosoft />}
<HorizontalSeparator visible />
<HorizontalSeparator />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: consider conditionally rendering the separator only when both social providers and password form are present, similar to SignInUpWorkspaceScopeForm

@Devessier Devessier force-pushed the fix-shrinked-horizontal-separator branch from 0551a73 to afc5678 Compare December 23, 2024 10:51
@lucasbordeau lucasbordeau enabled auto-merge (squash) December 30, 2024 16:57
@lucasbordeau lucasbordeau merged commit e1c99be into main Dec 30, 2024
22 checks passed
@lucasbordeau lucasbordeau deleted the fix-shrinked-horizontal-separator branch December 30, 2024 17:03
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-fc34cf31.json

Generated by 🚫 dangerJS against 00da5d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants