Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command menu action click #9285

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix command menu action click #9285

merged 1 commit into from
Dec 30, 2024

Conversation

bosiraphael
Copy link
Contributor

  • Fix typing
  • Fix onClick

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes type safety and click handling in the CommandMenu component by properly implementing the Command interface and correcting the onClick handler.

  • Fixed CommandGroupConfig interface in /packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx to use Command[] instead of any[]
  • Updated click handler from onClick to onCommandClick to match Command type definition in /packages/twenty-front/src/modules/command-menu/types/Command.ts
  • Ensures proper type checking for command menu items and their click handlers

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@bosiraphael bosiraphael enabled auto-merge (squash) December 30, 2024 17:05
@bosiraphael bosiraphael merged commit 7388f2b into main Dec 30, 2024
22 checks passed
@bosiraphael bosiraphael deleted the r-fix-action-click branch December 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants