Workflow phone number field #9324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-workflow-phone-number-field
branch
from
b5849e4 to
3c7228e
Compare
Devessier
approved these changes
Jan 2, 2025
| @@ -125,6 +128,8 @@ export const FormNumberFieldInput = ({ | |||
| /> | |||
| ) : null} | |||
| </FormFieldInputRowContainer> | |||
|
|
|||
| {hint ? <FormFieldHint>{hint}</FormFieldHint> : null} | |||
thomtrp
force-pushed
the
tt-workflow-phone-number-field
branch
from
3c7228e to
6ea4c2d
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds comprehensive phone number field functionality with country code selection and proper formatting support.
- Added new
FormPhoneFieldInputcomponent in/packages/twenty-front/src/modules/object-record/record-field/form-types/components/FormPhoneFieldInput.tsxcombining country code selection and phone number input - Added
FormCountryCodeSelectInputcomponent with flag icons and calling codes display in/packages/twenty-front/src/modules/object-record/record-field/form-types/components/FormCountryCodeSelectInput.tsx - Added
FormFieldHintcomponent in/packages/twenty-front/src/modules/object-record/record-field/form-types/components/FormFieldHint.tsxfor displaying helper text below form fields - Modified
Tagcomponent in/packages/twenty-ui/src/display/tag/components/Tag.tsxto supportpreventPaddingfor better form field integration - Added Storybook stories for testing and demonstrating the new phone field components
11 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
.../src/modules/object-record/record-field/form-types/components/FormCountryCodeSelectInput.tsx
Show resolved
Hide resolved
...y-front/src/modules/object-record/record-field/form-types/components/FormPhoneFieldInput.tsx
Show resolved
Hide resolved
| onPersist({ | ||
| primaryPhoneCountryCode: newCountry, | ||
| primaryPhoneCallingCode: newCallingCode, | ||
| primaryPhoneNumber: '', |
There was a problem hiding this comment.
style: resetting phone number on country change could lead to data loss - consider preserving it
Comment on lines
+35
to
+41
| const handleNumberChange = (number: string | number | null) => { | ||
| onPersist({ | ||
| primaryPhoneCountryCode: defaultValue?.primaryPhoneCountryCode || '', | ||
| primaryPhoneCallingCode: defaultValue?.primaryPhoneCallingCode || '', | ||
| primaryPhoneNumber: number ? `${number}` : '', | ||
| }); | ||
| }; |
There was a problem hiding this comment.
style: handleNumberChange should validate phone number format before persisting
Comment on lines
+24
to
+28
| export const Default: Story = { | ||
| args: { | ||
| label: 'Phone', | ||
| defaultValue: defaultPhoneValue, | ||
| }, |
There was a problem hiding this comment.
logic: Missing required onPersist prop in story args. This will cause runtime errors since FormPhoneFieldInput requires it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phone number field