Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple lightbox #656

Merged
merged 2 commits into from
Jan 24, 2024
Merged

add simple lightbox #656

merged 2 commits into from
Jan 24, 2024

Conversation

mercury233
Copy link
Contributor

image

非常简单的点击图片放大功能
我不会vue所以实现的方式可能有一些小问题

@imaegoo
Copy link
Member

imaegoo commented Jan 23, 2024

这种方案容易受到不同的博客主题的影响(比如被其他元素遮盖),所以暂不考虑合并

有更好的集成方案: https://www.imaegoo.com/2021/twikoo-lightgallery/

@mercury233
Copy link
Contributor Author

lightgallery的方案更加复杂,出现冲突的概率更高
解决遮盖问题只需要手动用css重设z-index,比改代码更简单

@imaegoo imaegoo merged commit 728eddd into twikoojs:main Jan 24, 2024
1 check passed
@imaegoo
Copy link
Member

imaegoo commented Jan 24, 2024

已修复 lint 错误,

感谢贡献

@mercury233 mercury233 deleted the patch-lightbox branch January 24, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants