-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
新增对 pushoo 中自定义 webhook 的支持,更新了 eslint 相关组件版本,解决本地开发环境依赖冲突 #776
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "twikoo", | |||
"version": "1.6.40", | |||
"version": "1.6.41", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请勿提交版本号,版本号由 @imaegoo 统一维护,只在发版时自动递增
"eslint": "^8.57.1", | ||
"eslint-config-standard": "^17.1.0", | ||
"eslint-plugin-import": "^2.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
勿升级 eslint,导致流水线不通过
` | ||
评论人:${NICK} ([${MAIL}](mailto:${MAIL})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余的行首空格
NICK, | ||
MAIL, | ||
IP, | ||
TEXT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
命名规则:小驼峰
url: pushContent.url, | ||
text: pushContent.TEXT, | ||
ip: pushContent.IP, | ||
nick: pushContent.NICK, | ||
mail: pushContent.MAIL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
与通知无关的内容不需要传给 pushoo
webhook 需要兼容更多的 hook,你的方案不够通用,只能适应一种 hook,鉴于这个需求比较个性化,你可以通过发布私有包的方式自用,不考虑合并进主分支中。 |
好吧… 我关掉这个 |
No description provided.