remove hypothesis (at least for now) #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 99.04% 99.05% +0.01%
==========================================
Files 44 45 +1
Lines 3887 3935 +48
Branches 520 523 +3
==========================================
+ Hits 3850 3898 +48
Misses 23 23
Partials 14 14
☔ View full report in Codecov by Sentry. |
dreid
reviewed
May 3, 2023
| yield DecodedURL.from_text("https://example.com") | ||
| yield DecodedURL.from_text("http://example.com/") | ||
| yield DecodedURL.from_text("https://example.com/é") | ||
| yield DecodedURL.from_text("https://súbdomain.example.com/ascii/path/") |
There was a problem hiding this comment.
Do you want a URL str that has a %-encoded path element here?
dreid
approved these changes
May 3, 2023
|
Thanks @dreid . Still need to get the robot to respect non-core reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #561
I am not entirely convinced we need Hypothesis at all, but if we do, when we reintroduce it we have to first do the work to make it deterministic in CI and to address the various deficiencies in Hyperlink's strategies if we want to use those.
(ugh I did a thing in the wrong tab, please ignore the other PR)