remove Procedure syntax using scalafix on the remaining Source scala …

…files

Final round of Procedure syntax removal using scalafix.
However, lint.scalafix cannot be enabled by default as the 3rdparty/ directory cannot be fixed.

NO_USER_HOOK=1

Differential Revision: https://phabricator.twitter.biz/D185091

server/src/test/scala/com/twitter/server/AdminHttpServerTest.scala

@@ -69,7 +69,7 @@ class AdminHttpServerTest extends FunSuite with Eventually with IntegrationPatie
 
   test("server serves and is closed properly") {
     val server = new TestTwitterServer {
-      override def main() {
+      override def main(): Unit = {
         checkServer(adminHttpServer)
         closeServer(this, adminHttpServer)
         Await.result(close(5.seconds))
@@ -80,7 +80,7 @@ class AdminHttpServerTest extends FunSuite with Eventually with IntegrationPatie
 
   test("shadow server serves and is closed properly") {
     val server = new TestTwitterServer with ShadowAdminServer {
-      override def main() {
+      override def main(): Unit = {
         checkServer(shadowHttpServer)
         // ShadowAdminServer does not listen for /quitquitquit
         // so send it to the admin server

server/src/test/scala/com/twitter/server/TwitterServerTest.scala

@@ -15,7 +15,7 @@ class TestTwitterServer extends TwitterServer {
 
   val bootstrapSeq = mutable.MutableList.empty[Symbol]
 
-  def main() {
+  def main(): Unit = {
     bootstrapSeq += 'Main
   }
 
@@ -61,7 +61,7 @@ class TwitterServerTest extends FunSuite {
 
   test("TwitterServer.main(args) executes without error when closed explicitly") {
     val twitterServer = new TestTwitterServer {
-      override def main() {
+      override def main(): Unit = {
         super.main()
         Await.result(close())
       }

slf4j-jdk14/src/test/scala/com/twitter/server/HandlersTest.scala

@@ -54,7 +54,7 @@ class HandlersTest extends FunSuite {
     val twitterServer = new TestTwitterServer {
       val mockExceptionHandler = new MockExceptionHandler
 
-      override def main() {
+      override def main(): Unit = {
         addAdminRoute(
           AdminHttpServer.mkRoute(
             path = "/exception_please.json",

slf4j-jdk14/src/test/scala/com/twitter/server/LogFormatTest.scala

@@ -9,7 +9,7 @@ import org.scalatest.junit.JUnitRunner
 
 @RunWith(classOf[JUnitRunner])
 class LogFormatTest extends FunSuite {
-  def testStringHandler(f: (Logger, StringHandler) => Unit) {
+  def testStringHandler(f: (Logger, StringHandler) => Unit): Unit = {
     val handler = new StringHandler
     handler.setFormatter(new com.twitter.server.logging.LogFormatter)