Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandbox Apps #848

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Sandbox Apps #848

wants to merge 11 commits into from

Conversation

iam4tune
Copy link
Contributor

@iam4tune iam4tune commented Nov 1, 2024

Pull Request

Modified content we have from our legacy documents for creating Sandbox apps on Cheaha.

Overview

Fixes #428

@iam4tune iam4tune self-assigned this Nov 1, 2024
@wwarriner
Copy link
Contributor

As discussed, let's separate out FeBio from this PR. Create a separate issue for it and we can add it in a future PR after the remaining content has been merged.

@wwarriner wwarriner added the pr: needs changes Review complete, needs changes label Nov 12, 2024
@iam4tune
Copy link
Contributor Author

I already took out the FEBio content, and created an issue to include FEBio in a future PR.

@iam4tune iam4tune added pr: review PR is ready for review and removed pr: needs changes Review complete, needs changes labels Nov 19, 2024
@iam4tune iam4tune added this to the Sprint 25-04 milestone Nov 19, 2024
wwarriner
wwarriner requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@wwarriner wwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Excellent cropping on the images. Some stylistic changes need to be made and then it should be good to go.

docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/images/sandbox_new_app_form.png Outdated Show resolved Hide resolved
@wwarriner wwarriner added pr: needs changes Review complete, needs changes and removed pr: review PR is ready for review labels Nov 21, 2024
@iam4tune iam4tune added pr: review PR is ready for review and removed pr: needs changes Review complete, needs changes labels Dec 3, 2024
@iam4tune iam4tune modified the milestones: Sprint 25-04, Sprint 25-05 Dec 3, 2024
wwarriner
wwarriner requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@wwarriner wwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I am excited for this one. I think we need a bit of work to explain a couple of things more explicitly, and a few rewordings.

docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
@wwarriner wwarriner added pr: needs changes Review complete, needs changes and removed pr: review PR is ready for review labels Dec 11, 2024
@iam4tune iam4tune added pr: review PR is ready for review and removed pr: needs changes Review complete, needs changes labels Dec 13, 2024
wwarriner
wwarriner requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@wwarriner wwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small typos and one minor change and it's good.

docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
docs/workflow_solutions/creating_sandbox_apps.md Outdated Show resolved Hide resolved
@wwarriner wwarriner removed the pr: review PR is ready for review label Jan 7, 2025
@wwarriner wwarriner added the pr: needs changes Review complete, needs changes label Jan 7, 2025
@iam4tune iam4tune added pr: merge PR is ready to merge and removed pr: needs changes Review complete, needs changes labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwarriner wwarriner wwarriner requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@iam4tune iam4tune

Labels
pr: merge PR is ready to merge
Projects
None yet
Milestone
Sprint 25-05
Development

Successfully merging this pull request may close these issues.

Sandbox apps on OOD
2 participants
@iam4tune @wwarriner