Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize child scopes #403

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

greeflas
Copy link
Contributor

Hello!

This is fix for #402.

I'll appreciate your feedback 🙌

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a772ad7) 98.40% compared to head (f6953c9) 98.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          22       22           
  Lines        1505     1507    +2     
=======================================
+ Hits         1481     1483    +2     
  Misses         15       15           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sywhang
Copy link
Contributor

sywhang commented Jan 16, 2024

Thanks @greeflas! Ideally we would add some type of visual representation to highlight the different scopes, but i think this is better than what we have for now. I'll take a look at the implementation later tonight

@sywhang sywhang self-assigned this Jan 16, 2024
Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sywhang that we will probably eventually want more clear demarcation of scopes, but for now this LGTM to at the least show module's constructors at all.

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@sywhang sywhang merged commit 45369ac into uber-go:master Jan 18, 2024
7 checks passed
@greeflas
Copy link
Contributor Author

Thank you, guys, for the feedback!

@greeflas greeflas mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants