-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize child scopes #403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 22 22
Lines 1505 1507 +2
=======================================
+ Hits 1481 1483 +2
Misses 15 15
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Thanks @greeflas! Ideally we would add some type of visual representation to highlight the different scopes, but i think this is better than what we have for now. I'll take a look at the implementation later tonight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @sywhang that we will probably eventually want more clear demarcation of scopes, but for now this LGTM to at the least show module's constructors at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the contribution!
Thank you, guys, for the feedback! |
Hello!
This is fix for #402.
I'll appreciate your feedback 🙌