fix: unique link credits #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add URL tracking for anchor tags to compute unique links in comments.
0x4007
reviewed
Nov 18, 2024
0x4007
reviewed
Nov 18, 2024
Co-authored-by: アレクサンダー.eth <4975670+0x4007@users.noreply.github.com>
Added regex to remove footnotes in data-purge-module.
Consolidate URL matching logic by reusing urlRegex across the module.
Removed nested structure for comments in reward-split.json to improve readability.
Merged
|
@whilefoo If you can have a look |
|
@gentlementlegen, this task has been idle for a while. Please provide an update. |
|
@0x4007 👀 |
|
I'm happy to get back to performing reviews - I just need the green light. |
0x4007
requested changes
Nov 25, 2024
Updated URL splitting to handle both hash and query parameters.
# Conflicts: # dist/index.js
|
Handle diffs in separate task if you can't do it quickly here. |
|
I will do it separately because that includes multiple different API calls and add quite some complexity if we need to treat all the comments history, and lots of testing. I'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #155
Depends on #181
QA:
Meniole#29 (comment)