-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli argument to pass the issue URL to the program #7
feat: cli argument to pass the issue URL to the program #7
Conversation
Looks good so far! |
@pavlovcik An example run can be found at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me. Will have more feedback after we test in production I suppose!
I just checked CI. Can you make it pass and then you can merge? |
@pavlovcik Are you talking about the current CI? Knip is out eternal problem of the rights to post to the pull-request, the other is simply that there is no build for this repo as it is an action. I believe however that Jest should be running so I will fix that. To properly run the tests, we should eventually need to link a |
873c863
into
ubiquity-os-marketplace:development
Resolves #6