Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli argument to pass the issue URL to the program #7

Conversation

gentlementlegen
Copy link
Member

Resolves #6

@0x4007
Copy link
Member

0x4007 commented Apr 2, 2024

Looks good so far!

@gentlementlegen gentlementlegen marked this pull request as ready for review April 3, 2024 02:01
@gentlementlegen gentlementlegen requested a review from 0x4007 April 3, 2024 02:01
@gentlementlegen
Copy link
Member Author

@pavlovcik An example run can be found at
https://github.com/gentlementlegen/conversation-rewards/actions/runs/8531619636/job/23372720740#step:3:123
Output is set so it can be re-used on a following step of a workflow.

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. Will have more feedback after we test in production I suppose!

@0x4007
Copy link
Member

0x4007 commented Apr 3, 2024

I just checked CI. Can you make it pass and then you can merge?

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Apr 3, 2024

@pavlovcik Are you talking about the current CI? Knip is out eternal problem of the rights to post to the pull-request, the other is simply that there is no build for this repo as it is an action. I believe however that Jest should be running so I will fix that.

To properly run the tests, we should eventually need to link a OPENAI_API_KEY in the secrets.

@0x4007
Copy link
Member

0x4007 commented Apr 4, 2024

To properly run the tests, we should eventually need to link a OPENAI_API_KEY in the secrets.

image

Can you make it pass and then you can merge?

Means you can merge when its ready. The reward wouldn't generate but I can simply regenerate the reward in this case. It is most operationally efficient to merge code optimistically, especially when your reviewer (me) says looks good.

@gentlementlegen gentlementlegen merged commit 873c863 into ubiquity-os-marketplace:development Apr 4, 2024
1 of 2 checks passed
@gentlementlegen gentlementlegen deleted the feat/cli-issue-url branch April 4, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept CLI argument for issue URL and ability to run as a GitHub Action
2 participants