fix: added tests and redactPrivateRepoComments

README.md

@@ -17,6 +17,7 @@ To set up the `.dev.vars` file, you will need to provide the following variables
     matchThreshold: 0.95
     warningThreshold: 0.75
     jobMatchingThreshold: 0.75
+    redactPrivateRepoComments: false
 ```
 
 

manifest.json

@@ -25,12 +25,17 @@
       "jobMatchingThreshold": {
         "default": 0.75,
         "type": "number"
+      },
+      "redactPrivateRepoComments": {
+        "default": false,
+        "type": "boolean"
       }
     },
     "required": [
       "matchThreshold",
       "warningThreshold",
-      "jobMatchingThreshold"
+      "jobMatchingThreshold",
+      "redactPrivateRepoComments"
     ]
   }
 }

src/handlers/add-comments.ts

@@ -10,7 +10,7 @@ export async function addComments(context: Context) {
   const markdown = payload.comment.body;
   const authorId = payload.comment.user?.id || -1;
   const nodeId = payload.comment.node_id;
-  const isPrivate = payload.repository.private;
+  const isPrivate = context.config.redactPrivateRepoComments;
   const issueId = payload.issue.node_id;
 
   try {

src/handlers/add-issue.ts

@@ -11,7 +11,7 @@ export async function addIssue(context: Context) {
   const markdown = payload.issue.body + " " + payload.issue.title || null;
   const authorId = payload.issue.user?.id || -1;
   const nodeId = payload.issue.node_id;
-  const isPrivate = payload.repository.private;
+  const isPrivate = context.config.redactPrivateRepoComments;
 
   try {
     if (!markdown) {

src/handlers/update-comments.ts

@@ -7,12 +7,11 @@ export async function updateComment(context: Context) {
     adapters: { supabase },
   } = context;
   const { payload } = context as { payload: CommentPayload };
-  const markdown = payload.comment.body;
   const authorId = payload.comment.user?.id || -1;
   const nodeId = payload.comment.node_id;
-  const isPrivate = payload.repository.private;
-  const issueId = payload.issue.node_id;
-
+  const issueId = payload.issue.node_id
+  const isPrivate = !context.config.redactPrivateRepoComments && payload.repository.private;
+  const markdown = payload.comment.body || null;
   // Fetch the previous comment and update it in the db
   try {
     if (!markdown) {

src/handlers/update-issue.ts

@@ -10,7 +10,7 @@ export async function updateIssue(context: Context) {
   const { payload } = context as { payload: IssuePayload };
   const payloadObject = payload;
   const nodeId = payload.issue.node_id;
-  const isPrivate = payload.repository.private;
+  const isPrivate = context.config.redactPrivateRepoComments;
   const markdown = payload.issue.body + " " + payload.issue.title || null;
   const authorId = payload.issue.user?.id || -1;
   // Fetch the previous issue and update it in the db

src/types/plugin-inputs.ts

@@ -23,6 +23,7 @@ export const pluginSettingsSchema = T.Object(
     matchThreshold: T.Number({ default: 0.95 }),
     warningThreshold: T.Number({ default: 0.75 }),
     jobMatchingThreshold: T.Number({ default: 0.75 }),
+    redactPrivateRepoComments: T.Boolean({ default: false }),
   },
   { default: {} }
 );

tests/__mocks__/adapter.ts

@@ -72,6 +72,43 @@ export function createMockAdapters(context: Context) {
           return commentMap.get(commentNodeId);
         }),
       } as unknown as Comment,
+
+      issue: {
+        findSimilarIssues: jest.fn(async (issueContent: string, threshold: number, currentIssueId: string) => {
+          // Return empty array for first issue in each test
+          if (currentIssueId === "warning1" || currentIssueId === "match1") {
+            return [];
+          }
+
+          // For warning threshold test (similarity around 0.8)
+          if (currentIssueId === "warning2") {
+            return [
+              {
+                issue_id: "warning1",
+                similarity: 0.8,
+              },
+            ];
+          }
+
+          // For match threshold test (similarity above 0.95)
+          if (currentIssueId === "match2") {
+            return [
+              {
+                issue_id: "match1",
+                similarity: 0.96,
+              },
+            ];
+          }
+
+          return [];
+        }),
+        createIssue: jest.fn(async () => {
+          // Implementation for createIssue
+        }),
+      },
+      fetchComments: jest.fn(async (issueId: string) => {
+        return Array.from(commentMap.values()).filter((comment) => comment.issue_id === issueId);
+      }),
     },
     voyage: {
       embedding: {

tests/__mocks__/db.ts

@@ -62,7 +62,7 @@ export const db = factory({
     deployments_url: String,
   },
   issue: {
-    id: primaryKey(Number),
+    node_id: primaryKey(String),
     number: Number,
     title: String,
     body: String,
@@ -78,6 +78,7 @@ export const db = factory({
     comments: Number,
     labels: Array,
     state: String,
+    closed: Boolean,
     locked: Boolean,
     assignee: nullable({
       login: String,
@@ -136,6 +137,7 @@ export const db = factory({
       login: String,
       id: Number,
     },
+    issue_id: String,
     author_association: String,
     html_url: String,
     issue_url: String,

tests/__mocks__/handlers.ts

@@ -1,5 +1,6 @@
 import { http, HttpResponse } from "msw";
 import { db } from "./db";
+
 /**
  * Intercepts the routes and returns a custom payload
  */
@@ -48,6 +49,21 @@ export const handlers = [
     item.body = body;
     return HttpResponse.json(item);
   }),
+  //Update issue
+  http.patch("https://api.github.com/repos/:owner/:repo/issues/:issue_number", async ({ params: { issue_number: issueNumber }, request }) => {
+    const { body } = await getValue(request.body);
+    const item = db.issue.findFirst({ where: { number: { equals: Number(issueNumber) } } });
+    if (!item) {
+      return new HttpResponse(null, { status: 404 });
+    }
+    item.body = body;
+    return HttpResponse.json(item);
+  }),
+
+  //Fetch comments for the issue
+  http.get("https://api.github.com/repos/:owner/:repo/issues/:issue_number/comments", ({ params: { issue_id: issueId } }) =>
+    HttpResponse.json(db.issueComments.findMany({ where: { issue_id: { equals: String(issueId) } } }))
+  ),
 ];
 
 async function getValue(body: ReadableStream<Uint8Array> | null) {
@@ -63,4 +79,5 @@ async function getValue(body: ReadableStream<Uint8Array> | null) {
       }
     }
   }
+  return {};
 }

tests/__mocks__/helpers.ts

@@ -1,6 +1,16 @@
 import { db } from "./db";
 import { STRINGS } from "./strings";
 import usersGet from "./users-get.json";
+import threshold95_1 from "../__sample__/match_threshold_95_1.json";
+import threshold95_2 from "../__sample__/match_threshold_95_2.json";
+import warning75_1 from "../__sample__/warning_threshold_75_1.json";
+import warning75_2 from "../__sample__/warning_threshold_75_2.json";
+import taskComplete from "../__sample__/task_complete.json";
+
+interface SampleIssue {
+  title: string;
+  issue_body: string;
+}
 
 /**
  * Helper function to setup tests.
@@ -34,14 +44,16 @@ export async function setupTests() {
 
   // Insert issues
   db.issue.create({
-    id: 1,
+    node_id: "1", //Node ID
     number: 1,
     title: "First Issue",
     body: "This is the body of the first issue.",
     user: {
       login: STRINGS.USER_1,
       id: 1,
     },
+    owner: STRINGS.USER_1,
+    repo: STRINGS.TEST_REPO,
     author_association: "OWNER",
     created_at: new Date().toISOString(),
     updated_at: new Date().toISOString(),
@@ -65,14 +77,16 @@ export async function setupTests() {
   });
 
   db.issue.create({
-    id: 2,
+    node_id: "2", //Node ID
     number: 2,
     title: "Second Issue",
     body: "This is the body of the second issue.",
     user: {
       login: STRINGS.USER_1,
       id: 1,
     },
+    owner: STRINGS.USER_1,
+    repo: STRINGS.TEST_REPO,
     author_association: "OWNER",
     created_at: new Date().toISOString(),
     updated_at: new Date().toISOString(),
@@ -96,7 +110,80 @@ export async function setupTests() {
   });
 }
 
-export function createComment(comment: string, commentId: number, nodeId: string) {
+export function createIssue(
+  issueBody: string,
+  issueNodeId: string,
+  issueTitle: string,
+  issueNumber: number,
+  issueUser: {
+    login: string;
+    id: number;
+  },
+  issueState: string,
+  issueCloseReason: string | null,
+  repo: string,
+  owner: string
+) {
+  const existingIssue = db.issue.findFirst({
+    where: {
+      node_id: {
+        equals: issueNodeId,
+      },
+    },
+  });
+  if (existingIssue) {
+    db.issue.update({
+      where: {
+        node_id: {
+          equals: issueNodeId,
+        },
+      },
+      data: {
+        body: issueBody,
+        title: issueTitle,
+        user: issueUser,
+        updated_at: new Date().toISOString(),
+        owner: owner,
+        repo: repo,
+        state: issueState,
+        state_reason: issueCloseReason,
+      },
+    });
+  } else {
+    db.issue.create({
+      node_id: issueNodeId,
+      body: issueBody,
+      title: issueTitle,
+      user: issueUser,
+      number: issueNumber,
+      created_at: new Date().toISOString(),
+      updated_at: new Date().toISOString(),
+      author_association: "OWNER",
+      state: issueState,
+      state_reason: issueCloseReason,
+      owner: owner,
+      repo: repo,
+      reactions: {
+        url: "",
+        total_count: 0,
+        "+1": 0,
+        "-1": 0,
+        laugh: 0,
+        hooray: 0,
+        confused: 0,
+        heart: 0,
+        rocket: 0,
+        eyes: 0,
+      },
+      timeline_url: "",
+      comments: 0,
+      labels: [],
+      locked: false,
+    });
+  }
+}
+
+export function createComment(comment: string, commentId: number, nodeId: string, issueNumber?: number) {
   const existingComment = db.issueComments.findFirst({
     where: {
       id: {
@@ -105,6 +192,17 @@ export function createComment(comment: string, commentId: number, nodeId: string
     },
   });
 
+  // Find the issue by nodeId to get its number
+  const issue = db.issue.findFirst({
+    where: {
+      node_id: {
+        equals: nodeId,
+      },
+    },
+  });
+
+  const targetIssueNumber = issueNumber || (issue ? issue.number : 1);
+
   if (existingComment) {
     db.issueComments.update({
       where: {
@@ -115,13 +213,14 @@ export function createComment(comment: string, commentId: number, nodeId: string
       data: {
         body: comment,
         updated_at: new Date().toISOString(),
+        issue_number: targetIssueNumber,
       },
     });
   } else {
     db.issueComments.create({
       id: commentId,
       body: comment,
-      issue_number: 1,
+      issue_number: targetIssueNumber,
       node_id: nodeId,
       user: {
         login: STRINGS.USER_1,
@@ -133,3 +232,16 @@ export function createComment(comment: string, commentId: number, nodeId: string
     });
   }
 }
+
+export function fetchSimilarIssues(type?: string): SampleIssue[] {
+  switch (type) {
+    case "warning_threshold_75":
+      return [warning75_1, warning75_2];
+    case "match_threshold_95":
+      return [threshold95_1, threshold95_2];
+    case "task_complete":
+      return [taskComplete];
+    default:
+      return [threshold95_1, threshold95_2];
+  }
+}

tests/__mocks__/strings.ts

@@ -15,4 +15,6 @@ export const STRINGS = {
   CONFIGURABLE_RESPONSE: "Hello, Code Reviewers!",
   INVALID_COMMAND: "/Goodbye",
   COMMENT_DOES_NOT_EXIST: "Comment does not exist",
+  SIMILAR_ISSUE: "Similar Issue",
+  SIMILAR_ISSUE_URL: "https://www.github.com/org/repo/issues",
 };

tests/__sample__/match_threshold_95_1.json

@@ -0,0 +1,4 @@
+{
+    "title": "Bug: NullPointerException in Python API Handler",
+    "issue_body": "Title: Bug: NullPointerException in Python API Handler\nDescription: A NullPointerException occurs in the get_user function of the Python API handler when a null value is passed for user_id. Implement a null check to handle this scenario.\nSteps to Reproduce: Pass a null user_id to get_user. Observe the exception in the API logs.\nExpected Behavior: Null values should be handled without causing an exception.\nCurrent Behavior: The function throws a NullPointerException.\nAttachments: Stack trace log."
+}

tests/__sample__/match_threshold_95_2.json

@@ -0,0 +1,4 @@
+{
+    "title": "Bug: NullPointerException in Python API Handler",
+    "issue_body": "Description: The get_user function in the Python API handler throws a NullPointerException when the user_id is not provided. This needs a null check to prevent the exception and handle invalid user IDs.\n\nSteps to reproduce: Call the get_user function with a null user_id. Check the exception in the API logs.\n\nExpected behavior: NullPointerException should be avoided with proper null handling.\n\nCurrent behavior: Exception NullPointerException is thrown.\n\nAttachments: Exception trace log."
+}

tests/__sample__/task_complete.json

@@ -0,0 +1,4 @@
+{
+    "title": "Review Cache Strategies for Java Service Layer to Handle High Load",
+    "issue_body": "Description: The Java service layer's performance deteriorates under high load, partly due to the absence of effective caching. Evaluate and implement advanced caching strategies to ensure the service layer performs optimally during peak usage.\nSteps to Reproduce:\nSimulate high load on the Java service layer.\nAnalyze performance metrics and identify bottlenecks.\nExpected Behavior: Service layer maintains stability and performance under high load with improved caching strategies.\nCurrent Behavior: Performance degradation and potential instability under high load.\nAttachments: N/A"
+}

tests/__sample__/warning_threshold_75_1.json

@@ -0,0 +1,5 @@
+{
+    "title": "Feature Request: Add Caching to Java Service Layer",
+    "issue_body": "Description: The Java service layer does not currently utilize caching, resulting in performance issues with frequent requests. Implement caching to improve performance for repeated queries.\nSteps to Reproduce: Make frequent requests to the Java service layer. Monitor performance and response times.\nExpected Behavior: Improved performance with caching enabled.\nCurrent Behavior: Slower response times due to lack of caching.\nAttachments: N/A"
+}
+