-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: metadata is properly built #42
fix: metadata is properly built #42
Conversation
What are the changesCurrently the metadata headers are broken and do not display any info when used through the SDK. Also, Workers could not display any relevant information either. This is fixed by this pull-request (thank you @Keyrxng for the code head start). I determined that the most important info we always use is:
So now a header would look like the following:
Which I think gives us the most important data and an easy way to find more detailed logs. For convenience, I also added an option to post message QA: Meniole/text-conversation-rewards#43 (not sure if you can see the metadata though but it's the one I copy pasted here). Workers will need to upload one more secret that will help finding the user, and enable an option in their Also at this time, not every plugin uses our SDK to post so this has to be updated over time. |
Co-authored-by: アレクサンダー.eth <4975670+0x4007@users.noreply.github.com>
Code changes look fine. Interested to see the rendered metadata in a QA example. |
@0x4007 Sorry didn't post QA because I figured you would not be able to see the metadata from my organization. Lemme display some results then. Made it visible here: Meniole/text-conversation-rewards#44 (comment) |
Looks informative but what is the second field with the value of your username? |
@0x4007 It is the name of the person that instigated the run. I thought it was useful information because many times we were wondering why some comments were posted, and it was because the person who posted these comments deleted them afterwards. |
Sure we can leave it then. |
Actually the invoker field should be last for search reasons. |
@gentlementlegen I think you missed my comment |
@whilefoo Apologies I did miss it, addressing this now. |
Resolves #41