-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: disable Cloudflare Kv #167
refactor: disable Cloudflare Kv #167
Conversation
Abstracted CloudflareKv to KvStore interface and added EmptyStore class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future you should at least describe context in your pull body.
We decided to disable the use of KV because the original purpose of tracking state between runs was to be able to run plugin chains in series, with the potential to make use of the output of one plugin as an input to another, similar to Github Actions.
We decided that due to us constantly hitting KV limits, and that none of our plugins depend on this behavior, that we can run all of them concurrently and not track state anymore.
I don't see any changes related to concurrency. Is this finished?
I thought it would just be about the KV, I an add the concurrency here too. |
Utilize Promise.all to concurrently handle plugin chains and improve efficiency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how you can prove QA so hope that you tested it.
@0x4007 Yeah sorry cannot link the kernel logs here, so here is a screenshot Even in the screenshot it is not clear that it is concurrent but it runs with the code from this PR. |
Abstracted CloudflareKv to KvStore interface and added EmptyStore class.