Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disable Cloudflare Kv #167

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

gentlementlegen
Copy link
Member

Abstracted CloudflareKv to KvStore interface and added EmptyStore class.

Abstracted CloudflareKv to KvStore interface and added EmptyStore class.
@gentlementlegen gentlementlegen marked this pull request as ready for review October 24, 2024 05:27
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future you should at least describe context in your pull body.

We decided to disable the use of KV because the original purpose of tracking state between runs was to be able to run plugin chains in series, with the potential to make use of the output of one plugin as an input to another, similar to Github Actions.

We decided that due to us constantly hitting KV limits, and that none of our plugins depend on this behavior, that we can run all of them concurrently and not track state anymore.


I don't see any changes related to concurrency. Is this finished?

@gentlementlegen
Copy link
Member Author

I thought it would just be about the KV, I an add the concurrency here too.

Utilize Promise.all to concurrently handle plugin chains and improve efficiency.
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how you can prove QA so hope that you tested it.

@gentlementlegen
Copy link
Member Author

@0x4007 Yeah sorry cannot link the kernel logs here, so here is a screenshot
image

Even in the screenshot it is not clear that it is concurrent but it runs with the code from this PR.

@0x4007 0x4007 merged commit ebf9635 into ubiquity-os:development Oct 24, 2024
3 checks passed
@gentlementlegen gentlementlegen linked an issue Oct 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make plugin invocation concurrently
2 participants