Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip posting help comment when no commands found #179

Merged

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Oct 30, 2024

Added a check to ensure no comment is posted if commands are empty. Note: there can be plugins enabled but without any command, which will result in the help command being skipped as well.

Resolves #152
QA: Meniole/ubiquity-os-kernel#18 (comment)

Added a check to ensure no comment is posted if commands are empty.
Updated test data to reflect new plugin names for accuracy.
@gentlementlegen gentlementlegen marked this pull request as ready for review October 30, 2024 04:06
src/github/handlers/help-command.ts Show resolved Hide resolved
@gentlementlegen gentlementlegen merged commit 686761e into ubiquity-os:development Oct 31, 2024
3 checks passed
@gentlementlegen gentlementlegen deleted the fix/help-menu branch October 31, 2024 06:47
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding The Help Menu
2 participants