Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix knip warnings in kernel repository #35

Conversation

gitcoindev
Copy link
Contributor

@gitcoindev gitcoindev commented Mar 18, 2024

  • Set correct entry points in knip.ts for ubiquibot-kernel repostiory to find all dependencies
  • add unlisted transitive dependencies to package.json that were imported directly

Resolves: #34

* Set correct entry points in knip.ts for ubiquibot-kernel repostiory to find all dependencies
* add unlisted transitive dependencies to package.json that were imported directly
* add no-unused-vars to two unused exports

Resolves: ubiquity-os#34
@gitcoindev gitcoindev requested a review from whilefoo as a code owner March 18, 2024 17:05
Copy link
Contributor

Unused dependencies (4)

Filename dependencies
package.json @octokit/webhooks-types
create-cloudflare
octokit
universal-github-app-jwt

Unused devDependencies (4)

Filename devDependencies
package.json @mswjs/data
esbuild
eslint-config-prettier
eslint-plugin-prettier

Unlisted dependencies (9)

Filename unlisted
src/github/github-client.ts @octokit/core
@octokit/types
@octokit/plugin-paginate-rest
@octokit/plugin-rest-endpoint-methods
@octokit/plugin-retry
@octokit/plugin-throttling
@octokit/auth-app
src/github/github-event-handler.ts @octokit/auth-app
src/github/utils/config.ts yaml

Unlisted binaries (5)

Filename binaries
package.json lsof
awk
.github/workflows/build.yml build
.github/workflows/bun-testing.yml i
.github/workflows/cspell.yml format:cspell

@gitcoindev
Copy link
Contributor Author

After merging all Knip warnings will be gone.

QA: https://github.com/gitcoindev/ubiquibot-kernel/actions/runs/8330594286/job/22795604012?pr=3

Also tested locally:

$ bun knip
$ knip --config .github/knip.ts
✂️  Excellent, Knip found no issues.

@gitcoindev gitcoindev requested a review from rndquu March 18, 2024 17:08
@rndquu rndquu requested review from gentlementlegen and removed request for rndquu March 18, 2024 20:40
@whilefoo whilefoo merged commit 9f219a4 into ubiquity-os:development Mar 19, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create correct Knip configuration for ubiquibot-kernel repository
3 participants