Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration load #40

Merged

Conversation

gentlementlegen
Copy link
Member

The configuration now does not fail to load when the target repo has none, nor if it is invalid. Instead it will use the default one. Also the merging of configurations has been fixed, and related tests have been added.

@molecula451
Copy link
Contributor

gentle can you check bun run failling?

src/github/utils/config.ts Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member Author

@molecula451 I fixed it but it still fails here because it's not updated on the development branch. Successful run here.

@gentlementlegen gentlementlegen requested a review from whilefoo May 18, 2024 07:37
@molecula451
Copy link
Contributor

@molecula451 I fixed it but it still fails here because it's not updated on the development branch. Successful run here.

@rndquu 👀

@molecula451 molecula451 merged commit bfda111 into ubiquity-os:development May 18, 2024
3 of 5 checks passed
@gentlementlegen gentlementlegen deleted the fix/configuration branch May 19, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants