-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/config installer #13
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
05d4451
feat: fetch manifests
Keyrxng 0f38940
chore: update manifest decoder and render
Keyrxng 7d2303f
chore: fetch manifests if no search
Keyrxng 9e37251
chore: format, cspell, eslint
Keyrxng 7a87205
chore: plugin installer ui init
Keyrxng aeaca20
chore: update main with new flow
Keyrxng 5246822
chore: remove methods, add activeSession check
Keyrxng 0dbe64c
chore: update types, remove table header
Keyrxng 90a5dd8
chore: update fetcher, decoder and parser
Keyrxng 6bd0063
feat: plugin config installer
Keyrxng 6528b65
chore: move fetch after render
Keyrxng 2b47572
chore: fetch plugin worker/action endpoints
Keyrxng 6c4442a
chore: create config with official url
Keyrxng 0a74c0f
chore: handle missing input
Keyrxng 7d3a95a
chore: ajv for validation
Keyrxng 35dbe02
chore: clean up parser
Keyrxng 42dc8cb
chore: renderer with ajv and clean up
Keyrxng e357d5f
chore: util fn exports
Keyrxng b7d7b7a
chore: remove plugin logic, back button
Keyrxng c4fbb9e
chore: update .github/empty-string-checker.ts
Keyrxng 02b048e
chore: update ts-template items, fix typo
Keyrxng 62c9c31
chore: eslint and deps update
Keyrxng 709ab4a
chore: update fix
Keyrxng 48d5076
Merge remote-tracking branch 'upstream/main' into feat/config-installer
Keyrxng 905e2ea
chore: remove app_id and private key env vars from build
Keyrxng 0817865
chore: remove typebox
Keyrxng 87afab8
chore: add error feedback on config write
Keyrxng 27b6a42
chore: prevent multiple handler bindings, teak push
Keyrxng 9e458a3
chore: toast main try catch error
Keyrxng 4c86cdf
chore: remove empty string
Keyrxng 40edcb7
chore: hardcode sb url and key
Keyrxng cc892e9
chore: ci tests temp fix
Keyrxng c074edb
chore: knip, format
Keyrxng 3b7a5ed
chore: use sdk method for user orgs
Keyrxng c23b12b
chore: remove auth token on sign out
Keyrxng 84a1554
chore: update readme instructions
Keyrxng 5a5e53b
chore: GH app > Oauth app changes
Keyrxng aba5a19
chore: update readme
Keyrxng 406cac7
chore: create config repo if none
Keyrxng 6688f35
chore: paths from sdk
Keyrxng 8ff9501
chore: knip
Keyrxng 5ce4b43
chore: rename to element-helper
Keyrxng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,40 @@ | ||
<!--- | ||
Insert the issue number of the task you are completing if within this repository, or paste the url of the task. | ||
|
||
// EXAMPLE | ||
Resolves https://github.com/ubiquity/ts-template/issues/75 | ||
--> | ||
|
||
Resolves # | ||
|
||
<!-- | ||
- You must link the issue number e.g. "Resolves #1234" | ||
- Please do not replace the keyword "Resolves" https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword | ||
<!--- | ||
We advise that you give a brief description of your changes, either that it meets | ||
the specification exactly as described or what you had to do outwith the spec to resolve it. | ||
This is not required but again, it is advised. | ||
|
||
// EXAMPLE | ||
Changes: | ||
- Refactored the authentication mechanism because the auth token wasn't being properly stored. | ||
- Removed unnecessary calls to render the login button. | ||
--> | ||
|
||
Changes: | ||
|
||
- ... | ||
|
||
<!--- | ||
NOTICE: This is required for all pull requests and will be requested by reviewers if not present. | ||
|
||
- Include a screenshot/video or some other visual confirmation that your changes solve the task | ||
- If this is not applicable, build a unit test to prove it works as intended | ||
|
||
// EXAMPLE | ||
QA: | ||
- <url to your plugin fork or test issue in your own org showcasing the end result> | ||
- <screenshot of some kind of UI fix> | ||
- <E2E video of using the software> | ||
--> | ||
|
||
QA: | ||
|
||
- ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,4 @@ static/dist | |
coverage | ||
junit.xml | ||
cypress/screenshots | ||
test-dashboard.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,8 @@ | ||
import { defineConfig } from "cypress"; | ||
const { defineConfig } = require("cypress"); | ||
|
||
export default defineConfig({ | ||
module.exports = defineConfig({ | ||
e2e: { | ||
setupNodeEvents() { | ||
// implement node event listeners here | ||
}, | ||
experimentalStudio: true, | ||
baseUrl: "http://localhost:8080", | ||
baseUrl: "http://127.0.0.1:8080", | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,3 @@ | ||
describe("Homepage tests", () => { | ||
it("Console is cleared of errors and warnings", () => { | ||
cy.visit("/", { | ||
onBeforeLoad(win) { | ||
cy.stub(win.console, "error").as("consoleError"); | ||
}, | ||
}); | ||
cy.get("@consoleError").should("not.be.called"); | ||
cy.get("body").should("exist"); | ||
cy.get("h1").should("exist"); | ||
}); | ||
it("todo", () => {}); | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the error test be more relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was failing for some reason so I just removed it as it was a no-op either way. Minimal tests will be added in #19